Re: [PATCH] Fix UB in shrink-wrapping (PR rtl-optimization/85167)

2018-04-03 Thread Richard Biener
On April 3, 2018 6:07:17 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >The bb_uses and bb_defs bitmaps are never used if !*split_p, the >comments >even describe why: > /* For the new created basic block, there is no dataflow info at all. > So skip the following dataflow update and check. */ >On

[PATCH] Fix UB in shrink-wrapping (PR rtl-optimization/85167)

2018-04-03 Thread Jakub Jelinek
Hi! The bb_uses and bb_defs bitmaps are never used if !*split_p, the comments even describe why: /* For the new created basic block, there is no dataflow info at all. So skip the following dataflow update and check. */ On the new bb in that case DF_LR_BB_INFO is NULL, so &(NULL->field) is