Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-08 Thread Jakub Jelinek
On Fri, Feb 08, 2019 at 10:02:27AM -0500, Michael Ploujnikov wrote: > On 2019-02-07 3:09 p.m., Jakub Jelinek wrote: > > On Thu, Feb 07, 2019 at 03:04:21PM -0500, Michael Ploujnikov wrote: > >> 2019-02-07 Michael Ploujnikov > >> > >>PR middle-end/89150 > >>* bitmap.c (test_bitmap_tree_mar

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-08 Thread Michael Ploujnikov
On 2019-02-07 3:09 p.m., Jakub Jelinek wrote: > On Thu, Feb 07, 2019 at 03:04:21PM -0500, Michael Ploujnikov wrote: >> 2019-02-07 Michael Ploujnikov >> >> PR middle-end/89150 >> * bitmap.c (test_bitmap_tree_marking): New test. >> (NOT_NULL_OR_GARBAGE): For shortening >> test_

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-07 Thread Jakub Jelinek
On Thu, Feb 07, 2019 at 03:04:21PM -0500, Michael Ploujnikov wrote: > 2019-02-07 Michael Ploujnikov > > PR middle-end/89150 > * bitmap.c (test_bitmap_tree_marking): New test. > (NOT_NULL_OR_GARBAGE): For shortening > test_bitmap_tree_marking. > (bitmap_c_tests): Ad

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-07 Thread Michael Ploujnikov
On 2019-02-04 11:39 a.m., Richard Biener wrote: > On February 4, 2019 5:07:00 PM GMT+01:00, Jeff Law wrote: >> On 2/4/19 6:15 AM, Richard Biener wrote: >>> >>> When I introduced tree-form bitmaps I forgot to think about GC. >>> The following drops the chain_prev annotation to make the marker >>> w

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-05 Thread Jeff Law
On 2/4/19 9:07 AM, Jeff Law wrote: > On 2/4/19 6:15 AM, Richard Biener wrote: >> >> When I introduced tree-form bitmaps I forgot to think about GC. >> The following drops the chain_prev annotation to make the marker >> work for trees. I've also maked the obstack member GTY skip >> (and prevent bit

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-04 Thread Richard Biener
On February 4, 2019 5:07:00 PM GMT+01:00, Jeff Law wrote: >On 2/4/19 6:15 AM, Richard Biener wrote: >> >> When I introduced tree-form bitmaps I forgot to think about GC. >> The following drops the chain_prev annotation to make the marker >> work for trees. I've also maked the obstack member GTY

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-04 Thread Jeff Law
On 2/4/19 6:15 AM, Richard Biener wrote: > > When I introduced tree-form bitmaps I forgot to think about GC. > The following drops the chain_prev annotation to make the marker > work for trees. I've also maked the obstack member GTY skip > (and prevent bitmap_obstack from gengtype processing) bec

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-04 Thread Richard Biener
On Mon, 4 Feb 2019, Steven Bosscher wrote: > On Mon, Feb 4, 2019 at 2:16 PM Richard Biener wrote: > > When I introduced tree-form bitmaps I forgot to think about GC. > > The following drops the chain_prev annotation to make the marker > > work for trees. > > I don't understand this patch. How ar

Re: [PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-04 Thread Steven Bosscher
On Mon, Feb 4, 2019 at 2:16 PM Richard Biener wrote: > When I introduced tree-form bitmaps I forgot to think about GC. > The following drops the chain_prev annotation to make the marker > work for trees. I don't understand this patch. How are the nodes in a bitmap tree now to be found for marking

[PATCH] Fix PR89150, GC of tree-form bitmaps

2019-02-04 Thread Richard Biener
When I introduced tree-form bitmaps I forgot to think about GC. The following drops the chain_prev annotation to make the marker work for trees. I've also maked the obstack member GTY skip (and prevent bitmap_obstack from gengtype processing) because the obstack isn't used for GC allocated bitma