Re: [PATCH] Fix PR87295

2019-01-28 Thread Jason Merrill
On 1/28/19 6:30 AM, Richard Biener wrote: On Mon, 28 Jan 2019, Richard Biener wrote: On Sat, 26 Jan 2019, Jason Merrill wrote: On Fri, Jan 25, 2019 at 7:57 AM Richard Biener wrote: The following fixes an ICE with -flto -ffat-lto-objects -fdebug-types-section -g where optimize_external_refs

Re: [PATCH] Fix PR87295

2019-01-28 Thread Richard Biener
On Mon, 28 Jan 2019, Richard Biener wrote: > On Sat, 26 Jan 2019, Jason Merrill wrote: > > > On Fri, Jan 25, 2019 at 7:57 AM Richard Biener wrote: > > > > > > The following fixes an ICE with -flto -ffat-lto-objects > > > -fdebug-types-section -g where optimize_external_refs does not > > > expect

Re: [PATCH] Fix PR87295

2019-01-28 Thread Richard Biener
On Sat, 26 Jan 2019, Jason Merrill wrote: > On Fri, Jan 25, 2019 at 7:57 AM Richard Biener wrote: > > > > The following fixes an ICE with -flto -ffat-lto-objects > > -fdebug-types-section -g where optimize_external_refs does not > > expect to see DW_AT_signature as made "local" by build_abbrev_ta

Re: [PATCH] Fix PR87295

2019-01-26 Thread Jason Merrill
On Fri, Jan 25, 2019 at 7:57 AM Richard Biener wrote: > > The following fixes an ICE with -flto -ffat-lto-objects > -fdebug-types-section -g where optimize_external_refs does not > expect to see DW_AT_signature as made "local" by build_abbrev_table(sic!). > > This is because we run optimize_extern

[PATCH] Fix PR87295

2019-01-25 Thread Richard Biener
The following fixes an ICE with -flto -ffat-lto-objects -fdebug-types-section -g where optimize_external_refs does not expect to see DW_AT_signature as made "local" by build_abbrev_table(sic!). This is because we run optimize_external_refs twice in this setup. The fix is to make the second run