Re: [PATCH] Fix PR64242

2018-12-04 Thread Jakub Jelinek
On Tue, Dec 04, 2018 at 11:20:38AM +0100, Christophe Lyon wrote: > This commit didn't fix the failure I reported on some arm targets, and > it introduced > a regression on aarch64-none-elf with -mabi=ilp32: > FAIL: gcc.c-torture/execute/pr64242.c -O0 execution test > Il seems the test timed-out.

Re: [PATCH] Fix PR64242

2018-12-04 Thread Christophe Lyon
On Mon, 3 Dec 2018 at 17:26, Jakub Jelinek wrote: > > Hi! > > Here is a fix for the testcase, so that it doesn't FAIL pretty much > everywhere. > > On Fri, Nov 30, 2018 at 04:07:31PM -0700, Jeff Law wrote: > > > PR middle-end/64242 > > > * gcc.c-torture/execute/pr64242.c: New test. > > THa

Re: [PATCH] Fix PR64242

2018-12-03 Thread Jeff Law
On 12/3/18 9:25 AM, Jakub Jelinek wrote: > Hi! > > Here is a fix for the testcase, so that it doesn't FAIL pretty much > everywhere. > > On Fri, Nov 30, 2018 at 04:07:31PM -0700, Jeff Law wrote: >>> PR middle-end/64242 >>> * gcc.c-torture/execute/pr64242.c: New test. >> THanks for trackin

Re: [PATCH] Fix PR64242

2018-12-03 Thread Jakub Jelinek
Hi! Here is a fix for the testcase, so that it doesn't FAIL pretty much everywhere. On Fri, Nov 30, 2018 at 04:07:31PM -0700, Jeff Law wrote: > > PR middle-end/64242 > > * gcc.c-torture/execute/pr64242.c: New test. > THanks for tracking this down. I'd like to have this run through my > n

Re: [PATCH] Fix PR64242

2018-12-03 Thread Christophe Lyon
On Mon, 3 Dec 2018 at 14:35, Richard Biener wrote: > > On Sat, Dec 1, 2018 at 12:07 AM Jeff Law wrote: > > > > On 11/29/18 12:26 PM, Wilco Dijkstra wrote: > > > Fix PR64242 - the middle end expansion for long jmp updates the > > > hard frame pointer before it reads the new stack pointer. This >

Re: [PATCH] Fix PR64242

2018-12-03 Thread Richard Biener
On Sat, Dec 1, 2018 at 12:07 AM Jeff Law wrote: > > On 11/29/18 12:26 PM, Wilco Dijkstra wrote: > > Fix PR64242 - the middle end expansion for long jmp updates the > > hard frame pointer before it reads the new stack pointer. This > > results in a corrupted stack pointer if the jmp buffer is a lo

Re: [PATCH] Fix PR64242

2018-11-30 Thread Jeff Law
On 11/29/18 12:26 PM, Wilco Dijkstra wrote: > Fix PR64242 - the middle end expansion for long jmp updates the > hard frame pointer before it reads the new stack pointer. This > results in a corrupted stack pointer if the jmp buffer is a local. > The obvious fix is to insert a temporary. > > AArch

[PATCH] Fix PR64242

2018-11-29 Thread Wilco Dijkstra
Fix PR64242 - the middle end expansion for long jmp updates the hard frame pointer before it reads the new stack pointer. This results in a corrupted stack pointer if the jmp buffer is a local. The obvious fix is to insert a temporary. AArch64 bootstrap & regress pass. OK to commit? ChangeLog: 2