Re: [PATCH] Fix PR63148 - two choices

2014-09-05 Thread Richard Biener
On Thu, 4 Sep 2014, Jeff Law wrote: > On 09/04/14 06:11, Richard Biener wrote: > > > > The following two patches each fix PR63148, a wrong-code issue > > caused by bogus array indices a-la > > &global_data.b[(sizetype) i + 536870911] which have a correct > > address when lowered but bogus index.

Re: [PATCH] Fix PR63148 - two choices

2014-09-04 Thread Jeff Law
On 09/04/14 06:11, Richard Biener wrote: The following two patches each fix PR63148, a wrong-code issue caused by bogus array indices a-la &global_data.b[(sizetype) i + 536870911] which have a correct address when lowered but bogus index. The case in question can be mitigated by disabling foldi

Re: [PATCH] Fix PR63148 - two choices

2014-09-04 Thread Richard Biener
On Thu, 4 Sep 2014, Jakub Jelinek wrote: > On Thu, Sep 04, 2014 at 02:11:26PM +0200, Richard Biener wrote: > > Sofar I have only fully tested removing try_move_mult_to_index > > on trunk which has some fallout that I have fixed and some > > fallout that should be addressed as followup. The patch

Re: [PATCH] Fix PR63148 - two choices

2014-09-04 Thread Jakub Jelinek
On Thu, Sep 04, 2014 at 02:11:26PM +0200, Richard Biener wrote: > Sofar I have only fully tested removing try_move_mult_to_index > on trunk which has some fallout that I have fixed and some > fallout that should be addressed as followup. The patch Doesn't that regress e.g. testcases where users w

[PATCH] Fix PR63148 - two choices

2014-09-04 Thread Richard Biener
The following two patches each fix PR63148, a wrong-code issue caused by bogus array indices a-la &global_data.b[(sizetype) i + 536870911] which have a correct address when lowered but bogus index. The case in question can be mitigated by disabling folding of (sizetype) i * 8 + 4294967288 to ((si