Re: [PATCH] Fix PR50204

2011-10-12 Thread Michael Matz
Hi, no need to test a phi argument with itself (testing arg0 != arg1 is not the right test, though, so remembering the candidate index): > @@ -1948,18 +1958,35 @@ get_continuation_for_phi (gimple phi, ao > until we hit the phi argument definition that dominates the other one. > */ >

Re: [PATCH] Fix PR50204

2011-10-12 Thread Richard Guenther
On Wed, 12 Oct 2011, Michael Matz wrote: > Hi, > > On Tue, 11 Oct 2011, Richard Guenther wrote: > > > Since we have the alias oracle we no longer optimize the testcase below > > because I initially restricted the stmt walking to give up for PHIs with > > more than 2 arguments because of compil

Re: [PATCH] Fix PR50204

2011-10-12 Thread Michael Matz
Hi, On Tue, 11 Oct 2011, Richard Guenther wrote: > Since we have the alias oracle we no longer optimize the testcase below > because I initially restricted the stmt walking to give up for PHIs with > more than 2 arguments because of compile-time complexity issues. But > it's easy to see that c

[PATCH] Fix PR50204

2011-10-11 Thread Richard Guenther
Since we have the alias oracle we no longer optimize the testcase below because I initially restricted the stmt walking to give up for PHIs with more than 2 arguments because of compile-time complexity issues. But it's easy to see that compile-time is not an issue when we reduce PHI args pairwise