Thanks for all the help! I'll get this tested and committed to trunk
today.
On Wed, 2012-01-11 at 13:11 +0100, Jakub Jelinek wrote:
> On Wed, Jan 11, 2012 at 10:57:28AM +0100, Richard Guenther wrote:
> > > + tree fndecl;
> > > +
> > > + if (!is_gimple_call (stmt))
> > > +return;
> > > +
> >
On Wed, Jan 11, 2012 at 10:57:28AM +0100, Richard Guenther wrote:
> > + tree fndecl;
> > +
> > + if (!is_gimple_call (stmt))
> > + return;
> > +
> > + fndecl = gimple_call_fndecl (stmt);
> > +
> > + if (fndecl
> > + && TREE_CODE (fndecl) == FUNCTION_DECL
>
> Not needed.
>
> > + &
> Well, just for record, the final version of patch seems to make sense for me
> ;)
> Thanks! It is an interesting side corner to say at least.
Of course one could craft an function with two builtin_constant_p calls and
the asm statement that is not dominated by either of them but still always
c
> I think it should be unconditionally restrict splitting (I suppose on the
> trunk the __builtin_constant_p is optimized away already).
>
> Btw, this will also disqualify any point below
>
> if (__builtin_constant_p (...))
>{
> ...
>}
>
> because after the if join all BBs are domi
On Tue, Jan 10, 2012 at 11:15 PM, William J. Schmidt
wrote:
> On Tue, 2012-01-10 at 09:42 -0600, William J. Schmidt wrote:
>>
>> On Tue, 2012-01-10 at 14:53 +0100, Richard Guenther wrote:
>> >
>> > Btw, this will also disqualify any point below
>> >
>> > if (__builtin_constant_p (...))
>> > {
On Tue, 2012-01-10 at 09:42 -0600, William J. Schmidt wrote:
>
> On Tue, 2012-01-10 at 14:53 +0100, Richard Guenther wrote:
> >
> > Btw, this will also disqualify any point below
> >
> > if (__builtin_constant_p (...))
> >{
> > ...
> >}
> >
> > because after the if join all BBs ar
On Tue, 2012-01-10 at 14:53 +0100, Richard Guenther wrote:
> On Tue, Jan 10, 2012 at 2:43 PM, William J. Schmidt
> wrote:
> > Greetings,
> >
> > This patch follows Richard Guenther's suggestion of 2011-07-05 in
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49642 to fix the problem in
> > gcc 4
On Tue, Jan 10, 2012 at 2:43 PM, William J. Schmidt
wrote:
> Greetings,
>
> This patch follows Richard Guenther's suggestion of 2011-07-05 in
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49642 to fix the problem in
> gcc 4.6. It prevents choosing a function split point that is dominated
> by a b
Greetings,
This patch follows Richard Guenther's suggestion of 2011-07-05 in
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49642 to fix the problem in
gcc 4.6. It prevents choosing a function split point that is dominated
by a builtin call to __builtin_constant_p.
The bug was marked fixed in 4.7 s
