Re: [PATCH] Fix PR44563 more

2015-03-13 Thread Richard Biener
On Fri, 13 Mar 2015, Jan Hubicka wrote: > > > CFG cleanup currently searches for calls that became noreturn and > > > fixes them up (splitting block and removing the fallthru). Previously > > > that was technically necessary as propagation may have turned an > > > indirect call into a direct nore

Re: [PATCH] Fix PR44563 more

2015-03-13 Thread Richard Biener
On Fri, 13 Mar 2015, Jan Hubicka wrote: > > > > > > Honza - I think we performed this in CFG cleanup for the sake of CFG > > > checking, not for the sake of prompt optimization, no? > > Aha, now I understand what you ask about. I guess it can be seen this way. > NORETURN calls are CFG altering

Re: [PATCH] Fix PR44563 more

2015-03-13 Thread Jan Hubicka
> > > > Honza - I think we performed this in CFG cleanup for the sake of CFG > > checking, not for the sake of prompt optimization, no? Aha, now I understand what you ask about. I guess it can be seen this way. NORETURN calls are CFG altering and veriy_flow_infowould indeed bomb. Honza

Re: [PATCH] Fix PR44563 more

2015-03-12 Thread Jan Hubicka
> > CFG cleanup currently searches for calls that became noreturn and > > fixes them up (splitting block and removing the fallthru). Previously > > that was technically necessary as propagation may have turned an > > indirect call into a direct noreturn call and the CFG verifier would > > have bar

Re: [PATCH] Fix PR44563 more

2015-03-12 Thread Richard Biener
On Tue, 10 Mar 2015, Richard Biener wrote: > > CFG cleanup currently searches for calls that became noreturn and > fixes them up (splitting block and removing the fallthru). Previously > that was technically necessary as propagation may have turned an > indirect call into a direct noreturn call

[PATCH] Fix PR44563 more

2015-03-10 Thread Richard Biener
CFG cleanup currently searches for calls that became noreturn and fixes them up (splitting block and removing the fallthru). Previously that was technically necessary as propagation may have turned an indirect call into a direct noreturn call and the CFG verifier would have barfed. Today we guar