Re: [PATCH] Fix PR c++/85400

2018-06-11 Thread Eric Botcazou
> Eric, do you plan to backport this to release branches? I don't think so, it isn't a regression and the workaround is trivial. -- Eric Botcazou

Re: [PATCH] Fix PR c++/85400

2018-06-11 Thread Jakub Jelinek
On Wed, May 09, 2018 at 12:05:34PM +0200, Eric Botcazou wrote: > > So it isn't clear to me if a cxx_make_decl_one_only is the way to go. Maybe > > doing the recalculation in comdat_linkage and maybe_make_one_only only > > would be sufficient. > > Patch to that effect attached, tested on x86-64/Li

Re: [PATCH] Fix PR c++/85400

2018-05-09 Thread Jason Merrill
OK. On Wed, May 9, 2018 at 6:05 AM, Eric Botcazou wrote: >> So it isn't clear to me if a cxx_make_decl_one_only is the way to go. Maybe >> doing the recalculation in comdat_linkage and maybe_make_one_only only >> would be sufficient. > > Patch to that effect attached, tested on x86-64/Linux, OK

Re: [PATCH] Fix PR c++/85400

2018-05-09 Thread Eric Botcazou
> So it isn't clear to me if a cxx_make_decl_one_only is the way to go. Maybe > doing the recalculation in comdat_linkage and maybe_make_one_only only > would be sufficient. Patch to that effect attached, tested on x86-64/Linux, OK for mainline? 2018-05-09 Eric Botcazou cp/ PR c++/8

Re: [PATCH] Fix PR c++/85400

2018-04-30 Thread Eric Botcazou
> It seems like we're likely to need the same thing when we get to > make_decl_one_only by other paths; perhaps we should put this > recalculation in a cxx_make_decl_one_only. There are 4 calls to make_decl_one_only in the cp/ directory: the one at stake here in comdat_linkage, 1 in maybe_make_on

Re: [PATCH] Fix PR c++/85400

2018-04-26 Thread Jason Merrill
On Thu, Apr 26, 2018 at 9:42 AM, Eric Botcazou wrote: > Hi, > > for the attached testcase compiled/linked with -shared -fPIC -O, the Solaris > linker chokes on SPARC because the generated code uses the local-dynamic TLS > model for a global symbol: > > ld: fatal: relocation error: R_SPARC_TLS_LDM_

[PATCH] Fix PR c++/85400

2018-04-26 Thread Eric Botcazou
Hi, for the attached testcase compiled/linked with -shared -fPIC -O, the Solaris linker chokes on SPARC because the generated code uses the local-dynamic TLS model for a global symbol: ld: fatal: relocation error: R_SPARC_TLS_LDM_HI22: file /var/tmp//ccKG6GQC.o: symbol Test::blah(int)::mything