Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Jeff Law via Gcc-patches
On 5/20/23 21:28, Andrew Pinski wrote: On Sat, May 20, 2023 at 8:25 PM Jeff Law wrote: On 5/20/23 21:05, Andrew Pinski wrote: On Sat, May 20, 2023 at 6:26 PM Jeff Law via Gcc-patches wrote: On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: The problem is I used expand_expr wit

Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Andrew Pinski via Gcc-patches
On Sat, May 20, 2023 at 8:32 PM Andrew Pinski wrote: > > On Sat, May 20, 2023 at 8:28 PM Andrew Pinski wrote: > > > > On Sat, May 20, 2023 at 8:25 PM Jeff Law wrote: > > > > > > > > > > > > On 5/20/23 21:05, Andrew Pinski wrote: > > > > On Sat, May 20, 2023 at 6:26 PM Jeff Law via Gcc-patches >

Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Andrew Pinski via Gcc-patches
On Sat, May 20, 2023 at 8:28 PM Andrew Pinski wrote: > > On Sat, May 20, 2023 at 8:25 PM Jeff Law wrote: > > > > > > > > On 5/20/23 21:05, Andrew Pinski wrote: > > > On Sat, May 20, 2023 at 6:26 PM Jeff Law via Gcc-patches > > > wrote: > > >> > > >> > > >> > > >> On 5/20/23 19:09, Andrew Pinski

Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Andrew Pinski via Gcc-patches
On Sat, May 20, 2023 at 8:25 PM Jeff Law wrote: > > > > On 5/20/23 21:05, Andrew Pinski wrote: > > On Sat, May 20, 2023 at 6:26 PM Jeff Law via Gcc-patches > > wrote: > >> > >> > >> > >> On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: > >>> The problem is I used expand_expr with the target

Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Jeff Law via Gcc-patches
On 5/20/23 21:05, Andrew Pinski wrote: On Sat, May 20, 2023 at 6:26 PM Jeff Law via Gcc-patches wrote: On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: The problem is I used expand_expr with the target but we don't want to use the target here as it is the wrong mode for the origina

Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Andrew Pinski via Gcc-patches
On Sat, May 20, 2023 at 6:26 PM Jeff Law via Gcc-patches wrote: > > > > On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: > > The problem is I used expand_expr with the target but > > we don't want to use the target here as it is the wrong > > mode for the original expression. The testcase wo

Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Jeff Law via Gcc-patches
On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: The problem is I used expand_expr with the target but we don't want to use the target here as it is the wrong mode for the original expression. The testcase would ICE deap down while trying to do a move to use the target. Anyways just call

[PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests

2023-05-20 Thread Andrew Pinski via Gcc-patches
The problem is I used expand_expr with the target but we don't want to use the target here as it is the wrong mode for the original expression. The testcase would ICE deap down while trying to do a move to use the target. Anyways just calling expand_expr with NULL_EXPR fixes the issue. Committed a