Re: GCC testsuite maintenance (was: [PATCH] Fix OpenACC vector_length parsing in fortran)

2016-07-25 Thread Mike Stump
On Jul 25, 2016, at 9:37 AM, Joseph Myers wrote: > > On Fri, 15 Jul 2016, Thomas Schwinge wrote: > >>> No, we want to have as little churn as possible in existing tests, the >>> general policy is to add new tests (not just for OpenACC/OpenMP, but for >>> all functionality). >> >> Hmm, that's so

Re: GCC testsuite maintenance (was: [PATCH] Fix OpenACC vector_length parsing in fortran)

2016-07-25 Thread Joseph Myers
On Fri, 15 Jul 2016, Thomas Schwinge wrote: > > No, we want to have as little churn as possible in existing tests, the > > general policy is to add new tests (not just for OpenACC/OpenMP, but for > > all functionality). > > Hmm, that's something I had not been aware of, and I can't find this > co

GCC testsuite maintenance (was: [PATCH] Fix OpenACC vector_length parsing in fortran)

2016-07-15 Thread Thomas Schwinge
Hi! Including in case others also have opinions on "GCC testsuite maintenance". On Fri, 15 Jul 2016 10:21:13 +0200, Jakub Jelinek wrote: > On Fri, Jul 15, 2016 at 09:44:25AM +0200, Thomas Schwinge wrote: > > Does that me we (erroneously) accept any random junk after [...] > > No. The thing is

Re: [PATCH] Fix OpenACC vector_length parsing in fortran

2016-07-15 Thread Jakub Jelinek
On Thu, Jul 14, 2016 at 07:05:52PM -0700, Cesar Philippidis wrote: > Is this OK for trunk and gcc6? See other mail for trunk approval, just want to comment on the "and gcc6", it doesn't apply to gcc6, you can add the testcase there, but gcc 6 matches vector_length before vector, the bug has been i

Re: [PATCH] Fix OpenACC vector_length parsing in fortran

2016-07-15 Thread Jakub Jelinek
On Fri, Jul 15, 2016 at 09:44:25AM +0200, Thomas Schwinge wrote: > Hi! > > On Thu, 14 Jul 2016 19:05:52 -0700, Cesar Philippidis > wrote: > > The fortran FE is currently scanning for the vector clause before > > vector_length. That's a problem match_oacc_clause_gwv matches 'vector' > > without l

Re: [PATCH] Fix OpenACC vector_length parsing in fortran

2016-07-15 Thread Thomas Schwinge
Hi! On Thu, 14 Jul 2016 19:05:52 -0700, Cesar Philippidis wrote: > The fortran FE is currently scanning for the vector clause before > vector_length. That's a problem match_oacc_clause_gwv matches 'vector' > without looking for whatever follows it. The correction I made here was > to scan for ve

[PATCH] Fix OpenACC vector_length parsing in fortran

2016-07-14 Thread Cesar Philippidis
The fortran FE is currently scanning for the vector clause before vector_length. That's a problem match_oacc_clause_gwv matches 'vector' without looking for whatever follows it. The correction I made here was to scan for vector_length before vector. Is this OK for trunk and gcc6? Cesar 2016-07-14