Re: [PATCH] Fix ICF sem_function::merge (PR target/63892)

2015-02-22 Thread Jakub Jelinek
On Sat, Feb 21, 2015 at 01:24:55PM +, Iain Sandoe wrote: > P.S. The patch does solve a problem with ADT/SmallVectorTests.cpp in llvm > suite (with generation of a varargs thunk). > However, it does not appear to restore sibcall-3 for m32 darwin (see. pr63892 > for updated analysis). > > gcc

Re: [PATCH] Fix ICF sem_function::merge (PR target/63892)

2015-02-21 Thread Iain Sandoe
Hi Jakub, Martin, On 20 Feb 2015, at 16:42, Jeff Law wrote: > On 02/20/15 07:48, Jakub Jelinek wrote: >> Hi! >> >> As written in the PR, the sibcall-3.c testcase fails on Darwin, because >> !sem_item::target_supports_symbol_aliases_p () and we don't really try >> redirect_callers, even when that

Re: [PATCH] Fix ICF sem_function::merge (PR target/63892)

2015-02-20 Thread Jeff Law
On 02/20/15 07:48, Jakub Jelinek wrote: Hi! As written in the PR, the sibcall-3.c testcase fails on Darwin, because !sem_item::target_supports_symbol_aliases_p () and we don't really try redirect_callers, even when that is the best way to perform ICF (both original and alias are local). Bootstr

[PATCH] Fix ICF sem_function::merge (PR target/63892)

2015-02-20 Thread Jakub Jelinek
Hi! As written in the PR, the sibcall-3.c testcase fails on Darwin, because !sem_item::target_supports_symbol_aliases_p () and we don't really try redirect_callers, even when that is the best way to perform ICF (both original and alias are local). Bootstrapped/regtested on x86_64-linux and i686-l