Re: [PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-21 Thread Christophe Lyon
On 21 November 2017 at 09:14, Richard Biener wrote: > On Mon, 20 Nov 2017, Jakub Jelinek wrote: > >> Hi! >> >> Apparently ARM can do the widening SImode multiply only using a libcall, >> so the recently changed expand_mul_overflow ignores it at first, then >> sees possibility to use the HImode cod

Re: [PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-21 Thread Richard Biener
On Mon, 20 Nov 2017, Jakub Jelinek wrote: > Hi! > > Apparently ARM can do the widening SImode multiply only using a libcall, > so the recently changed expand_mul_overflow ignores it at first, then > sees possibility to use the HImode code, but uses expand_simple_binop > with OPTAB_DIRECT which re

Re: [PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-20 Thread Jeff Law
On 11/20/2017 02:07 PM, Jakub Jelinek wrote: > Hi! > > Apparently ARM can do the widening SImode multiply only using a libcall, > so the recently changed expand_mul_overflow ignores it at first, then > sees possibility to use the HImode code, but uses expand_simple_binop > with OPTAB_DIRECT which

[PATCH] Fix ICEs from expand_mul_overflow (PR target/82981)

2017-11-20 Thread Jakub Jelinek
Hi! Apparently ARM can do the widening SImode multiply only using a libcall, so the recently changed expand_mul_overflow ignores it at first, then sees possibility to use the HImode code, but uses expand_simple_binop with OPTAB_DIRECT which requires actual HImode optabs, which ARM doesn't have, it