Re: [PATCH] Fix ICE with extend_ref_init_temps of structured binding (PR c++/81197)

2017-12-15 Thread Jason Merrill
On 12/04/2017 07:00 PM, Jakub Jelinek wrote: @@ -1291,7 +1291,56 @@ write_unqualified_name (tree decl) { found = true; gcc_assert (DECL_ASSEMBLER_NAME_SET_P (decl)); - write_source_name (DECL_ASSEMBLER_NAME (decl)); + if (VAR_P (decl) + && DECL_DECOMPOSITIO

[PATCH] Fix ICE with extend_ref_init_temps of structured binding (PR c++/81197)

2017-12-04 Thread Jakub Jelinek
Hi! We were calling cp_finish_decl before cp_finish_decomp, so that the latter has the initializer finalized and can decompose it, and cp_finish_decomp was mangling the decl if needed. Unfortunately, as the following testcase shows, sometimes we need it mangled already earlier, during that cp_fini