Re: [PATCH] Fix ICE with __builtin_stack_save (PR c/90898)

2019-11-19 Thread Richard Biener
On Wed, 20 Nov 2019, Jakub Jelinek wrote: > Hi! > > I agree that we shouldn't have made __builtin_stack_{save,restore} public, > but I'd fear it is too late to remove it now (and replace by internal fn), > I'd think some code might use it to control when e.g. alloca will be > released. As the co

Re: [PATCH] Fix ICE with __builtin_stack_save (PR c/90898)

2019-11-19 Thread Jeff Law
On 11/19/19 4:58 PM, Jakub Jelinek wrote: > Hi! > > I agree that we shouldn't have made __builtin_stack_{save,restore} public, > but I'd fear it is too late to remove it now (and replace by internal fn), > I'd think some code might use it to control when e.g. alloca will be > released. As the com

[PATCH] Fix ICE with __builtin_stack_save (PR c/90898)

2019-11-19 Thread Jakub Jelinek
Hi! I agree that we shouldn't have made __builtin_stack_{save,restore} public, but I'd fear it is too late to remove it now (and replace by internal fn), I'd think some code might use it to control when e.g. alloca will be released. As the comment on insert_clobber* says, the addition of the clob