Re: [PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-11 Thread Jeff Law
On 12/11/2015 01:13 PM, Jakub Jelinek wrote: On Fri, Dec 11, 2015 at 07:30:59AM +0100, Richard Biener wrote: So, to fix ICE on the following testcase, we can either do what the patch does, or could conditionalize both the calculate_dominance_info and free_dominance_info in the convert_scalars_to

Re: [PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-11 Thread Jakub Jelinek
On Fri, Dec 11, 2015 at 07:30:59AM +0100, Richard Biener wrote: > >So, to fix ICE on the following testcase, we can either do what the > >patch > >does, or could conditionalize both the calculate_dominance_info and > >free_dominance_info in the convert_scalars_to_vector function (stv > >pass) > >on

Re: [PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-10 Thread Richard Biener
On December 10, 2015 9:11:16 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >It seems some passes in between the combiner and ira aren't prepared to >update dominance info. It usually is not a problem, because already >before >the combiner we call free_dominance_info. But we now have a new i?86 >stv

Re: [PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-10 Thread Jeff Law
On 12/10/2015 01:11 PM, Jakub Jelinek wrote: Hi! It seems some passes in between the combiner and ira aren't prepared to update dominance info. It usually is not a problem, because already before the combiner we call free_dominance_info. But we now have a new i?86 stv pass that is injected aft

[PATCH] Fix ICE with -fno-if-conversion (PR rtl-optimization/68730)

2015-12-10 Thread Jakub Jelinek
Hi! It seems some passes in between the combiner and ira aren't prepared to update dominance info. It usually is not a problem, because already before the combiner we call free_dominance_info. But we now have a new i?86 stv pass that is injected after the combiner that computes dominators but do