Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl (PR middle-end/82095)

2017-09-06 Thread Jakub Jelinek
On Wed, Sep 06, 2017 at 09:29:25AM -0600, Jeff Law wrote: > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > > trunk? > > > > 2017-09-05 Jakub Jelinek > > > > PR middle-end/82095 > > * varasm.c (categorize_decl_for_section): Use SECCAT_TBSS for TLS vars

Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl (PR middle-end/82095)

2017-09-06 Thread Jeff Law
On 09/05/2017 03:16 PM, Jakub Jelinek wrote: > Hi! > > If a DECL_THREAD_LOCAL_P decl has NULL DECL_INITIAL and > -fzero-initialized-in-bss (the default), we ICE starting with > r251602, which changed bss_initializer_p: > + /* Do not put constants into the .bss section, they belong in a readonly >

Re: [PATCH] Fix ICE in categorize_decl_for_section with TLS decl (PR middle-end/82095)

2017-09-05 Thread Richard Biener
On September 5, 2017 11:16:53 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >If a DECL_THREAD_LOCAL_P decl has NULL DECL_INITIAL and >-fzero-initialized-in-bss (the default), we ICE starting with >r251602, which changed bss_initializer_p: >+ /* Do not put constants into the .bss section, they belong

[PATCH] Fix ICE in categorize_decl_for_section with TLS decl (PR middle-end/82095)

2017-09-05 Thread Jakub Jelinek
Hi! If a DECL_THREAD_LOCAL_P decl has NULL DECL_INITIAL and -fzero-initialized-in-bss (the default), we ICE starting with r251602, which changed bss_initializer_p: + /* Do not put constants into the .bss section, they belong in a readonly + section. */ + return (!TREE_READONLY (decl) +