Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-03-02 Thread Jeff Law via Gcc-patches
On 2/26/21 8:24 AM, Mikael Pettersson via Gcc-patches wrote: > On Fri, Feb 5, 2021 at 2:59 PM Arnaud Charlet wrote: We'd rather not have PR references in the source files, so please remove it (it will be there as part of the commit log and git annotate). OK with the comment

Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-26 Thread Mikael Pettersson via Gcc-patches
On Fri, Feb 5, 2021 at 2:59 PM Arnaud Charlet wrote: > > > > We'd rather not have PR references in the source files, so please remove > > > it > > > (it will be there as part of the commit log and git annotate). > > > > > > OK with the comment updated. > > > > Thanks, here's the revised patch. >

Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-05 Thread Arnaud Charlet
> > We'd rather not have PR references in the source files, so please remove it > > (it will be there as part of the commit log and git annotate). > > > > OK with the comment updated. > > Thanks, here's the revised patch. OK, thanks. > gcc/ada/ > > 2021-02-05 Mikael Pettersson > > P

Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-05 Thread Mikael Pettersson via Gcc-patches
On Fri, Feb 5, 2021 at 9:35 AM Arnaud Charlet wrote: > > > This fixes the bootstrap failure with Ada on Cygwin since the switch > > to C++11. The configure checks detect that fileno_unlocked () is > > present, but when Ada's cstreams.c is compiled in C++11 mode, > > does not declare it, causing a

Re: [PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-05 Thread Arnaud Charlet
> This fixes the bootstrap failure with Ada on Cygwin since the switch > to C++11. The configure checks detect that fileno_unlocked () is > present, but when Ada's cstreams.c is compiled in C++11 mode, > does not declare it, causing a hard error. > > Fixed by defining _GNU_SOURCE before including

[PATCH] Fix Ada bootstrap failure on Cygwin since switch to C++11 (PR98590)

2021-02-03 Thread Mikael Pettersson via Gcc-patches
This fixes the bootstrap failure with Ada on Cygwin since the switch to C++11. The configure checks detect that fileno_unlocked () is present, but when Ada's cstreams.c is compiled in C++11 mode, does not declare it, causing a hard error. Fixed by defining _GNU_SOURCE before including . Ok for t