Re: [PATCH] Fix ARM exception handling (PR target/89093)

2019-04-24 Thread Ian Lance Taylor
On Mon, Apr 22, 2019 at 2:14 AM Jakub Jelinek wrote: > > As detailed in the PR, unlike most other targets, on ARM EABI the floating > point registers are saved lazily, when EH personality routine calls > __gnu_unwind_frame (usually in the CONTINUE_UNWINDING macro). > That means the unwinder itself

Re: [PATCH] Fix ARM exception handling (PR target/89093)

2019-04-24 Thread Eric Botcazou
> The Ada changes need those guards because the file is compiled by both > the system compiler and by the newly built compilers; when compiled by > system compiler, as the FE is built with -fno-exceptions I'd hope the EH > stuff isn't really used there and at least until GCC 9.1 is released we have

Re: [PATCH] Fix ARM exception handling (PR target/89093)

2019-04-23 Thread Jakub Jelinek
On Tue, Apr 23, 2019 at 09:17:50AM +0100, Ramana Radhakrishnan wrote: > > Ok for trunk? > > Ok. Thanks a lot for working on this and fixing the rest of this up. > I've been busy with a few other things. Thanks. Based on this and Iain and Jonathan's acks, I've committed the patch except for the

Re: [PATCH] Fix ARM exception handling (PR target/89093)

2019-04-23 Thread Jonathan Wakely
On 22/04/19 11:14 +0200, Jakub Jelinek wrote: Hi! As detailed in the PR, unlike most other targets, on ARM EABI the floating point registers are saved lazily, when EH personality routine calls __gnu_unwind_frame (usually in the CONTINUE_UNWINDING macro). That means the unwinder itself and the pe

Re: [PATCH] Fix ARM exception handling (PR target/89093)

2019-04-23 Thread Ramana Radhakrishnan
On Mon, Apr 22, 2019 at 10:15 AM Jakub Jelinek wrote: > > Hi! > > As detailed in the PR, unlike most other targets, on ARM EABI the floating > point registers are saved lazily, when EH personality routine calls > __gnu_unwind_frame (usually in the CONTINUE_UNWINDING macro). > That means the unwind

Re: [PATCH] Fix ARM exception handling (PR target/89093)

2019-04-22 Thread Iain Buclaw
On Mon, 22 Apr 2019 at 11:15, Jakub Jelinek wrote: > > Not sure about libphobos D stuff, does it need to go through upstream and > is libdruntime/gcc/deh.d compiled by compilers other than GDC? > It is not part of upstream, I could make that clearer in libphobos/README.gcc if there's uncertainty.

[PATCH] Fix ARM exception handling (PR target/89093)

2019-04-22 Thread Jakub Jelinek
Hi! As detailed in the PR, unlike most other targets, on ARM EABI the floating point registers are saved lazily, when EH personality routine calls __gnu_unwind_frame (usually in the CONTINUE_UNWINDING macro). That means the unwinder itself and the personality routines (and whatever other functions