Re: [PATCH] Fix -fstack-protector* on darwin/mingw etc. (PR target/85644)

2018-11-22 Thread Uros Bizjak
On Wed, Nov 21, 2018 at 11:21 PM Jakub Jelinek wrote: > > Hi! > > As I wrote in the PR, before PR81708 commits, > while i386 defaulted to SSP_TLS rather than SSP_GLOBAL on everything but > Android, the -mstack-protector-guard= switch controlled pretty much > whether the i386.md special stack prote

Re: [PATCH] Fix -fstack-protector* on darwin/mingw etc. (PR target/85644)

2018-11-21 Thread Jakub Jelinek
On Wed, Nov 21, 2018 at 11:21:18PM +0100, Jakub Jelinek wrote: > As I wrote in the PR, before PR81708 commits, Note, e.g. in 4.8, the stack_protector_* patterns weren't guarded with something like TARGET_SSP_TLS_GUARD but with !TARGET_HAS_BIONIC, which just means it was incorrectly implemented for

[PATCH] Fix -fstack-protector* on darwin/mingw etc. (PR target/85644)

2018-11-21 Thread Jakub Jelinek
Hi! As I wrote in the PR, before PR81708 commits, while i386 defaulted to SSP_TLS rather than SSP_GLOBAL on everything but Android, the -mstack-protector-guard= switch controlled pretty much whether the i386.md special stack protector patterns are used (if tls) or whether generic code is used (glo