Re: [PATCH] Fix -fcompare-debug issues in IPA-ICF (PR lto/78211)

2016-11-28 Thread Jan Hubicka
> On Mon, Nov 28, 2016 at 11:52:53AM +0100, Jan Hubicka wrote: > > > > IPA-ICF performs some code-generation visible changes from hash table > > > > traversal, where the hash values can be different between -g and -g0 > > > > (I bet it hashes DECL_UID in somewhere, perhaps other things). > > > > >

Re: [PATCH] Fix -fcompare-debug issues in IPA-ICF (PR lto/78211)

2016-11-28 Thread Jakub Jelinek
On Mon, Nov 28, 2016 at 11:52:53AM +0100, Jan Hubicka wrote: > > > IPA-ICF performs some code-generation visible changes from hash table > > > traversal, where the hash values can be different between -g and -g0 > > > (I bet it hashes DECL_UID in somewhere, perhaps other things). > > > > It should

Re: [PATCH] Fix -fcompare-debug issues in IPA-ICF (PR lto/78211)

2016-11-28 Thread Jan Hubicka
> > Hi! > > > > IPA-ICF performs some code-generation visible changes from hash table > > traversal, where the hash values can be different between -g and -g0 > > (I bet it hashes DECL_UID in somewhere, perhaps other things). > > It should not - the hash is stable for LTO streaming. > I think ICF

Re: [PATCH] Fix -fcompare-debug issues in IPA-ICF (PR lto/78211)

2016-11-28 Thread Jan Hubicka
> Hi! > > IPA-ICF performs some code-generation visible changes from hash table > traversal, where the hash values can be different between -g and -g0 > (I bet it hashes DECL_UID in somewhere, perhaps other things). It should not - the hash is stable for LTO streaming. I think ICF merging -g and

Re: [PATCH] Fix -fcompare-debug issues in IPA-ICF (PR lto/78211)

2016-11-28 Thread Richard Biener
On Fri, 25 Nov 2016, Jakub Jelinek wrote: > Hi! > > IPA-ICF performs some code-generation visible changes from hash table > traversal, where the hash values can be different between -g and -g0 > (I bet it hashes DECL_UID in somewhere, perhaps other things). > The following patch fixes it by addin

[PATCH] Fix -fcompare-debug issues in IPA-ICF (PR lto/78211)

2016-11-25 Thread Jakub Jelinek
Hi! IPA-ICF performs some code-generation visible changes from hash table traversal, where the hash values can be different between -g and -g0 (I bet it hashes DECL_UID in somewhere, perhaps other things). The following patch fixes it by adding a vector next to the hash table, which tracks the gro