Re: [PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-16 Thread Eric Botcazou
> Given the ill-formed nature of __builtin_unreachable, I think the > sensible thing is to require BARRIERs to match as well. If we don't, > then we could consider paths which differ only in the existence of a > BARRIER. If we cross jump them, then we either lose the > BARRIER/__builtin_unreachab

Re: [PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-15 Thread Jeff Law
On 12/14/2015 01:14 PM, Jakub Jelinek wrote: Hi! rtx_renumbered_equal_p considers two LABEL_REFs equivalent if they have the same next_real_insn, unfortunately next_real_insn doesn't ignore debug insns. It ignores BARRIERs/JUMP_TABLE_DATA insns too, which is IMHO not desirable either, so this p

Re: [PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-15 Thread Jeff Law
On 12/15/2015 02:13 PM, Jakub Jelinek wrote: On Tue, Dec 15, 2015 at 09:51:15PM +0100, Eric Botcazou wrote: rtx_renumbered_equal_p considers two LABEL_REFs equivalent if they have the same next_real_insn, unfortunately next_real_insn doesn't ignore debug insns. It ignores BARRIERs/JUMP_TABLE_DA

Re: [PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-15 Thread Jakub Jelinek
On Tue, Dec 15, 2015 at 09:51:15PM +0100, Eric Botcazou wrote: > > rtx_renumbered_equal_p considers two LABEL_REFs equivalent if they > > have the same next_real_insn, unfortunately next_real_insn doesn't ignore > > debug insns. It ignores BARRIERs/JUMP_TABLE_DATA insns too, which is IMHO > > not

Re: [PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-15 Thread Eric Botcazou
> rtx_renumbered_equal_p considers two LABEL_REFs equivalent if they > have the same next_real_insn, unfortunately next_real_insn doesn't ignore > debug insns. It ignores BARRIERs/JUMP_TABLE_DATA insns too, which is IMHO > not desirable either, so this patch uses next_nonnote_nondebug_insn instead

[PATCH] Fix -fcompare-debug issue in cross-jumping (PR rtl-optimization/65980)

2015-12-14 Thread Jakub Jelinek
Hi! rtx_renumbered_equal_p considers two LABEL_REFs equivalent if they have the same next_real_insn, unfortunately next_real_insn doesn't ignore debug insns. It ignores BARRIERs/JUMP_TABLE_DATA insns too, which is IMHO not desirable either, so this patch uses next_nonnote_nondebug_insn instead (w