Re: [PATCH] Fix -Wduplicate-branches ICE in inchash::add_expr (PR c++/86025)

2018-06-03 Thread Richard Biener
On Sun, 3 Jun 2018, Jakub Jelinek wrote: > Hi! > > The second argument of OMP_CRITICAL is IDENTIFIER_NODE, but we were ICEing > on that with -Wduplicate-branches, because we didn't know how to hash it. > operand_equal_p handles it the way it should, only pointer equal > IDENTIFIER_NODEs are the s

[PATCH] Fix -Wduplicate-branches ICE in inchash::add_expr (PR c++/86025)

2018-06-03 Thread Jakub Jelinek
Hi! The second argument of OMP_CRITICAL is IDENTIFIER_NODE, but we were ICEing on that with -Wduplicate-branches, because we didn't know how to hash it. operand_equal_p handles it the way it should, only pointer equal IDENTIFIER_NODEs are the same. Bootstrapped/regtested on x86_64-linux and i686-