Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-06-02 Thread Jonathan Wakely via Gcc-patches
On 24/05/20 15:43 +0200, François Dumont via Libstdc++ wrote: Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterator as the output so that it is transform into an output to pointer. Ok to co

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-06-02 Thread François Dumont via Gcc-patches
Hi Any feedback regarding this patch ? François On 26/05/20 1:45 pm, François Dumont wrote: On 24/05/20 3:43 pm, François Dumont wrote: Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterato

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-26 Thread François Dumont via Gcc-patches
On 24/05/20 3:43 pm, François Dumont wrote: Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterator as the output so that it is transform into an output to pointer. Ignore this remark, I had

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-24 Thread François Dumont via Gcc-patches
Now tested in C++98 mode, there was indeed a small problem. I even wonder if I shouldn't have extend the std::copy overload to any call with deque iterator as the output so that it is transform into an output to pointer. Ok to commit ? François On 23/05/20 6:37 pm, Jonathan Wakely wrote: O

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-23 Thread Jonathan Wakely via Gcc-patches
On 22/05/20 22:57 +0200, François Dumont via Libstdc++ wrote: On 21/05/20 2:17 pm, Jonathan Wakely wrote: Why is the optimization not done for C++03 mode? I did it this way because the new std::copy overload rely on std::copy_n implementation details which is a C++11 algo. It looks like

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-23 Thread François Dumont via Gcc-patches
On 22/05/20 10:57 pm, François Dumont wrote: On 21/05/20 2:17 pm, Jonathan Wakely wrote: Why is the optimization not done for C++03 mode? I did it this way because the new std::copy overload rely on std::copy_n implementation details which is a C++11 algo. It looks like the uses of 'auto'

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-22 Thread François Dumont via Gcc-patches
On 21/05/20 2:17 pm, Jonathan Wakely wrote: Why is the optimization not done for C++03 mode? I did it this way because the new std::copy overload rely on std::copy_n implementation details which is a C++11 algo. It looks like the uses of 'auto' can be reaplced easily, and __enable_if_t<> c

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-21 Thread Jonathan Wakely via Gcc-patches
On 07/05/20 09:12 +0200, François Dumont via Libstdc++ wrote:     This patch purpose is to make sure that existing std::copy/std::copy_n overloads for char* will also be used for std::deque iterators when dealing with istreambuf_iterator. It also make sure that it still works when _GLIBCXX_

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-19 Thread François Dumont via Gcc-patches
No chance to review this ? On 07/05/20 9:12 am, François Dumont wrote:     This patch purpose is to make sure that existing std::copy/std::copy_n overloads for char* will also be used for std::deque iterators when dealing with istreambuf_iterator. It also make sure that it still works when _G

Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-14 Thread François Dumont via Gcc-patches
Now fully tested, ok to commit ? On 07/05/20 9:12 am, François Dumont wrote:     This patch purpose is to make sure that existing std::copy/std::copy_n overloads for char* will also be used for std::deque iterators when dealing with istreambuf_iterator. It also make sure that it still works w

[PATCH] Extend std::copy/std::copy_n char* overload to deque iterator

2020-05-07 Thread François Dumont via Gcc-patches
    This patch purpose is to make sure that existing std::copy/std::copy_n overloads for char* will also be used for std::deque iterators when dealing with istreambuf_iterator. It also make sure that it still works when _GLIBCXX_DEBUG is activated.     * include/bits/stl_algo.h (__copy_n_a): M