Re: [PATCH] Ensure that dump calls are guarded with dump_enabled_p

2018-11-12 Thread Richard Biener
On Sat, 10 Nov 2018, David Malcolm wrote: > On Mon, 2018-10-22 at 16:08 +0200, Richard Biener wrote: > > On Mon, 22 Oct 2018, David Malcolm wrote: > > > > > On Mon, 2018-10-22 at 15:56 +0200, Richard Biener wrote: > > > [...snip...] > > > > > > > This is what I finally applied for the original p

Re: [PATCH] Ensure that dump calls are guarded with dump_enabled_p

2018-11-11 Thread Segher Boessenkool
On Sun, Nov 11, 2018 at 04:01:42PM -0500, David Malcolm wrote: > On Sun, 2018-11-11 at 12:10 -0700, Martin Sebor wrote: > > > +#define VERIFY_DUMP_ENABLED_P \ > > > + do { \ > > > +gcc_assert (dump_enabled_p ()); \ > > > +if (!dump_enabled_p ())

Re: [PATCH] Ensure that dump calls are guarded with dump_enabled_p

2018-11-11 Thread David Malcolm
On Sun, 2018-11-11 at 12:10 -0700, Martin Sebor wrote: > On 11/10/2018 07:57 PM, David Malcolm wrote: > > On Mon, 2018-10-22 at 16:08 +0200, Richard Biener wrote: > > > On Mon, 22 Oct 2018, David Malcolm wrote: > > > > > > > On Mon, 2018-10-22 at 15:56 +0200, Richard Biener wrote: > > > > [...snip

Re: [PATCH] Ensure that dump calls are guarded with dump_enabled_p

2018-11-11 Thread Martin Sebor
On 11/10/2018 07:57 PM, David Malcolm wrote: On Mon, 2018-10-22 at 16:08 +0200, Richard Biener wrote: On Mon, 22 Oct 2018, David Malcolm wrote: On Mon, 2018-10-22 at 15:56 +0200, Richard Biener wrote: [...snip...] This is what I finally applied for the original patch after fixing the above i

[PATCH] Ensure that dump calls are guarded with dump_enabled_p

2018-11-10 Thread David Malcolm
On Mon, 2018-10-22 at 16:08 +0200, Richard Biener wrote: > On Mon, 22 Oct 2018, David Malcolm wrote: > > > On Mon, 2018-10-22 at 15:56 +0200, Richard Biener wrote: > > [...snip...] > > > > > This is what I finally applied for the original patch after > > > fixing > > > the above issue. > > > > >