Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-12 Thread Richard Biener
On Sun, Jan 11, 2015 at 1:39 PM, Bernd Edlinger wrote: > Hi Richard, > > On Fri, 9 Jan 2015 17:19:57, Richard Biener wrote: >> >> >> Yes. As said, you generally need to run folding results through >> force_gimple_operand. >> >> Richard. >> > > > I have now used force_gimple_operand instead of spe

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-11 Thread Bernd Edlinger
Hi Richard, On Fri, 9 Jan 2015 17:19:57, Richard Biener wrote: > > > Yes. As said, you generally need to run folding results through > force_gimple_operand. > > Richard. > I have now used force_gimple_operand instead of special casing the VIEW_CONVERT_EXPRs. And I see that all Ada test cases s

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On January 9, 2015 4:10:44 PM CET, Bernd Edlinger wrote: >On Fri, 9 Jan 2015 14:04:27, Richard Biener wrote: >> >>> >>> FYI: the VIEW_CONVERT_EXPR did not fail in the >>> gcc_checking_assert (is_gimple_addressable (base)) >>> but much later, somewhere in tree-cfg.c it dropped out. >> >> How did i

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
On Fri, 9 Jan 2015 14:04:27, Richard Biener wrote: > >> >> FYI: the VIEW_CONVERT_EXPR did not fail in the >> gcc_checking_assert (is_gimple_addressable (base)) >> but much later, somewhere in tree-cfg.c it dropped out. > > How did it fail there? It doesn't look like &VIEW_CONVERT_EXPR > is forbidde

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On Fri, Jan 9, 2015 at 1:44 PM, Bernd Edlinger wrote: > > > On Fri, 9 Jan 2015 13:30:45, Jakub Jelinke wrote: >> >> On Fri, Jan 09, 2015 at 01:12:09PM +0100, Bernd Edlinger wrote: > should be equivalent to > > if (DECL_P (base) && !may_be_aliased (base)) > return false; > >

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
On Fri, 9 Jan 2015 13:30:45, Jakub Jelinke wrote: > > On Fri, Jan 09, 2015 at 01:12:09PM +0100, Bernd Edlinger wrote: should be equivalent to if (DECL_P (base) && !may_be_aliased (base)) return false; is that right? >>> >>> Yes, well, not exactly, but I wonder if its

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Jakub Jelinek
On Fri, Jan 09, 2015 at 01:12:09PM +0100, Bernd Edlinger wrote: > >> should be equivalent to > >> > >> if (DECL_P (base) && !may_be_aliased (base)) > >> return false; > >> > >> is that right? > > > > Yes, well, not exactly, but I wonder if its worth doing the extra check > > if you only check decl

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
On Fri, 9 Jan 2015 12:04:26, Richard Biener wrote: > >>> >>> There may be multiple VIEW_CONVERT_EXPRs in a reference chain >>> so simply stripping the outermost only doesn't work (the assert). >>> >> >> Hmm, that did not happen in any of the Ada tests in ada/acats nor in gnat.dg, >> but with Ada an

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On Fri, Jan 9, 2015 at 11:21 AM, Bernd Edlinger wrote: > Hi, > > On Fri, 9 Jan 2015 10:57:14, Richard Biener wrote: >> >> On Mon, Jan 5, 2015 at 9:00 PM, Jeff Law wrote: >>> On 01/03/15 06:49, Bernd Edlinger wrote: Hi, I was experimenting with enabling TSAN for Ada recently. >

RE: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Bernd Edlinger
Hi, On Fri, 9 Jan 2015 10:57:14, Richard Biener wrote: > > On Mon, Jan 5, 2015 at 9:00 PM, Jeff Law wrote: >> On 01/03/15 06:49, Bernd Edlinger wrote: >>> >>> Hi, >>> >>> I was experimenting with enabling TSAN for Ada recently. >>> I think this gives rather interesting results. >>> >>> The Instru

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-09 Thread Richard Biener
On Mon, Jan 5, 2015 at 9:00 PM, Jeff Law wrote: > On 01/03/15 06:49, Bernd Edlinger wrote: >> >> Hi, >> >> I was experimenting with enabling TSAN for Ada recently. >> I think this gives rather interesting results. >> >> The Instrumentation worked almost out of the box, we just have >> the problem

Re: [PATCH] Enable experimental TSAN support for Ada

2015-01-05 Thread Jeff Law
On 01/03/15 06:49, Bernd Edlinger wrote: Hi, I was experimenting with enabling TSAN for Ada recently. I think this gives rather interesting results. The Instrumentation worked almost out of the box, we just have the problem that it is not gimple-OK to fold something like "& VIEW_CONVERT_EXPR(x)

[PATCH] Enable experimental TSAN support for Ada

2015-01-03 Thread Bernd Edlinger
Hi, I was experimenting with enabling TSAN for Ada recently. I think this gives rather interesting results. The Instrumentation worked almost out of the box, we just have the problem that it is not gimple-OK to fold something like "& VIEW_CONVERT_EXPR(x)", and this happens in Ada all the time. B