Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Yury Gribov
On 09/05/2014 01:28 PM, Jakub Jelinek wrote: Though, for that option the default is yes for ubsan purposes, while asan wants a default to no, so it is unclear how to solve that. Either different option for asan recovery, or tristate option etc. Currently I force set it on encountering -fsaniti

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Jakub Jelinek
On Fri, Sep 05, 2014 at 12:33:54PM +0400, Yury Gribov wrote: > On 09/05/2014 12:23 PM, Dmitry Vyukov wrote: > >>I didn't find a good way to achieve this. See, normal asan reporting > >>functions > >>have a noreturn attribute (defined in sanitizer.def) which can't be changed > >>depending on cmdline

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Yury Gribov
On 09/05/2014 12:59 PM, Andrey Ryabinin wrote: And how does it work if someone wants to try -fsanitize=address -fsanitize-recover. Seems you didn't touch libsanitzer in this patch, so I guess this will cause link time error, right ? Exactly, Asan team does not want recovery mode for userspace

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Andrey Ryabinin
On 09/05/2014 10:54 AM, Yury Gribov wrote: > Hi all, > > This patch enables -fsanitize-recover for KASan by default. This causes KASan > to continue execution after error in case of inline instrumentation. This > feature is needed because > - reports during early bootstrap won't even be printed

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Yury Gribov
On 09/05/2014 12:23 PM, Dmitry Vyukov wrote: I didn't find a good way to achieve this. See, normal asan reporting functions have a noreturn attribute (defined in sanitizer.def) which can't be changed depending on cmdline flag. I have not looked at the code in detail. But it looks weird to me tha

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Dmitry Vyukov
On Fri, Sep 5, 2014 at 12:12 PM, Yury Gribov wrote: > On 09/05/2014 11:32 AM, Dmitry Vyukov wrote: >> >> Can we do it w/o doubling number of runtime entry points? > > > I didn't find a good way to achieve this. See, normal asan reporting > functions > have a noreturn attribute (defined in sanitize

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Yury Gribov
On 09/05/2014 11:32 AM, Dmitry Vyukov wrote: Can we do it w/o doubling number of runtime entry points? I didn't find a good way to achieve this. See, normal asan reporting functions have a noreturn attribute (defined in sanitizer.def) which can't be changed depending on cmdline flag. Looks

Re: [PATCH] Enable -fsanitize-recover for KASan

2014-09-05 Thread Dmitry Vyukov
On Fri, Sep 5, 2014 at 10:54 AM, Yury Gribov wrote: > Hi all, > > This patch enables -fsanitize-recover for KASan by default. This causes > KASan to continue execution after error in case of inline instrumentation. > This feature is needed because > - reports during early bootstrap won't even be p

[PATCH] Enable -fsanitize-recover for KASan

2014-09-04 Thread Yury Gribov
Hi all, This patch enables -fsanitize-recover for KASan by default. This causes KASan to continue execution after error in case of inline instrumentation. This feature is needed because - reports during early bootstrap won't even be printed - needed to run all tests w/o rebooting machine for e