Re: [PATCH] Don't insert white space in 'orig_option_with_args_text' for OPT_l

2012-03-13 Thread Ludovic Courtès
Hi, (Cc: Paul Brook.) "Joseph S. Myers" skribis: > On Mon, 12 Mar 2012, Ludovic Courtès wrote: > >> The patch below solves the problem in a gfortran-specific way. WDYT? > > I think that's the right approach for this issue. The previous patch was produced with ‘diff -b’. Here’s a fixed one. L

Re: [PATCH] Don't insert white space in 'orig_option_with_args_text' for OPT_l

2012-03-12 Thread Joseph S. Myers
On Mon, 12 Mar 2012, Ludovic Court?s wrote: > The patch below solves the problem in a gfortran-specific way. WDYT? I think that's the right approach for this issue. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Don't insert white space in 'orig_option_with_args_text' for OPT_l

2012-03-12 Thread Ludovic Courtès
Hi, Thanks for the review. "Joseph S. Myers" skribis: > On Fri, 9 Mar 2012, Ludovic Courtès wrote: > >> * gcc/opts-common.c (generate_option): Don't insert white space in >> `canonical_option' when OPT_INDEX is OPT_l. > > No, opts-common.c should not have special cases for individual

Re: [PATCH] Don't insert white space in 'orig_option_with_args_text' for OPT_l

2012-03-09 Thread Joseph S. Myers
On Fri, 9 Mar 2012, Ludovic Court?s wrote: > * gcc/opts-common.c (generate_option): Don't insert white space in > `canonical_option' when OPT_INDEX is OPT_l. No, opts-common.c should not have special cases for individual options like that. The canonical form has the separate argumen