Re: [PATCH] Don't insert ENDBR after NOTE_INSN_DELETED_LABEL

2019-05-31 Thread H.J. Lu
On Fri, May 31, 2019 at 10:43 AM Jakub Jelinek wrote: > > On Fri, May 31, 2019 at 09:53:42AM -0700, H.J. Lu wrote: > > 2019-05-31 H.J. Lu > > Hongtao Liu > > > > gcc/ > > > > PR target/89355 > > * config/i386/i386.c (ix86_init_large_pic_reg): Don't set > > LABEL_PR

Re: [PATCH] Don't insert ENDBR after NOTE_INSN_DELETED_LABEL

2019-05-31 Thread Jakub Jelinek
On Fri, May 31, 2019 at 09:53:42AM -0700, H.J. Lu wrote: > 2019-05-31 H.J. Lu > Hongtao Liu > > gcc/ > > PR target/89355 > * config/i386/i386.c (ix86_init_large_pic_reg): Don't set > LABEL_PRESERVE_P. Why this change? It is both not needed and undesirable, the l

[PATCH] Don't insert ENDBR after NOTE_INSN_DELETED_LABEL

2019-05-31 Thread H.J. Lu
On Tue, May 28, 2019 at 10:33 AM Jeff Law wrote: > > On 5/28/19 9:48 AM, Jakub Jelinek wrote: > > On Tue, May 28, 2019 at 08:30:59AM -0700, H.J. Lu wrote: > >>> We shouldn't generate ENDBR in that case, nothing can goto to bar > >>> (otherwise > >>> it would remain a normal label, not a deleted l