Re: [PATCH] Don't assume __secure_getenv is available

On Fri, May 12, 2017 at 11:02 AM, Thomas Schwinge wrote: > Hi! > > On Fri, 12 May 2017 10:26:59 +0300, Janne Blomqvist > wrote: >> On Fri, May 12, 2017 at 10:23 AM, Thomas Schwinge >> wrote: >> > On Thu, 27 Apr 2017 21:50:51 +0300, Janne Blomqvist >> > wrote: >> >> [...], retain the support f

Re: [PATCH] Don't assume __secure_getenv is available

Hi! On Fri, 12 May 2017 10:26:59 +0300, Janne Blomqvist wrote: > On Fri, May 12, 2017 at 10:23 AM, Thomas Schwinge > wrote: > > On Thu, 27 Apr 2017 21:50:51 +0300, Janne Blomqvist > > wrote: > >> [...], retain the support for __secure_getenv but call it only via a > >> weak reference. > >> >

Re: [PATCH] Don't assume __secure_getenv is available

On Fri, May 12, 2017 at 10:23 AM, Thomas Schwinge wrote: > Hi! > > On Thu, 27 Apr 2017 21:50:51 +0300, Janne Blomqvist > wrote: >> [...], retain the support for __secure_getenv but call it only via a >> weak reference. >> >> Regtested on x86_64-pc-linux-gnu, Ok for trunk, 7.x when it reopens, >>

Re: [PATCH] Don't assume __secure_getenv is available

Hi! On Thu, 27 Apr 2017 21:50:51 +0300, Janne Blomqvist wrote: > [...], retain the support for __secure_getenv but call it only via a > weak reference. > > Regtested on x86_64-pc-linux-gnu, Ok for trunk, 7.x when it reopens, > 6, 5? Hmm, how has this been tested? Because: > --- a/libgfortran

Re: [PATCH] Don't assume __secure_getenv is available

On 05/07/2017 11:37 PM, Janne Blomqvist via fortran wrote: > PING > > On Thu, Apr 27, 2017 at 9:55 PM, Janne Blomqvist > wrote: >> On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist >> wrote: >> [snip] >> >> And on top of that patch this simple typo fix: >> >> diff --git a/libgfortran/runtime/envi

Re: [PATCH] Don't assume __secure_getenv is available

PING On Thu, Apr 27, 2017 at 9:55 PM, Janne Blomqvist wrote: > On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist > wrote: > [snip] > > And on top of that patch this simple typo fix: > > diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c > index 969dcdf..f488e87 100644 > --

Re: [PATCH] Don't assume __secure_getenv is available

On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist wrote: [snip] And on top of that patch this simple typo fix: diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c index 969dcdf..f488e87 100644 --- a/libgfortran/runtime/environ.c +++ b/libgfortran/runtime/environ.c @@ -46,7

[PATCH] Don't assume __secure_getenv is available

Glibc 2.17 made __secure_getenv an officially supported function, and renamed it secure_getenv. The libgfortran configure has checked for both of these, per https://sourceware.org/glibc/wiki/Tips_and_Tricks/secure_getenv. Unfortunately, while the dynamical library (libc.so) retains the __secure_ge