Re: [PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Pierre-Marie de Rodat
On 05/10/2016 05:20 PM, Jakub Jelinek wrote: gcc/ * dwarf2out.c (resolve_args_picking_1): Consider DW_OP_neg as an unary operation, not a binary one. Ok. This is committed. Thank you Jakub for the quick feedback! -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Jakub Jelinek
On Tue, May 10, 2016 at 05:06:59PM +0200, Pierre-Marie de Rodat wrote: > When the DWARF back-end generates DW_OP_neg operations in DWARF > procedures, we get an ICE because of inconsistent stack usage > computation for the embedding expression. This is because > resolve_args_picking_1 thinks DW_OP_

[PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Pierre-Marie de Rodat
Hello, When the DWARF back-end generates DW_OP_neg operations in DWARF procedures, we get an ICE because of inconsistent stack usage computation for the embedding expression. This is because resolve_args_picking_1 thinks DW_OP_neg is a binary operation (pops 2 stack slots, pushes 1) whereas it rea