Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-09-13 Thread Tom de Vries
On 8/17/18 6:29 AM, Omar Sandoval wrote: > I don't have commit rights (first time contributor), so if this change is okay > could it please be applied? Hi, thanks for the patch, I've committed the approved version. [ In case you don't have one already ... ] if you want to continue contributing,

Re: [PING][PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-09-13 Thread Richard Biener
On Thu, 13 Sep 2018, Tom de Vries wrote: > On 9/4/18 5:59 PM, Tom de Vries wrote: > > [ Adding Jason as addressee ] > > > > On 08/28/2018 08:20 PM, Omar Sandoval wrote: > >> On Fri, Aug 17, 2018 at 12:16:07AM -0700, Omar Sandoval wrote: > >>> On Thu, Aug 16, 2018 at 11:54:53PM -0700, Omar Sandova

[PING][PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-09-13 Thread Tom de Vries
On 9/4/18 5:59 PM, Tom de Vries wrote: > [ Adding Jason as addressee ] > > On 08/28/2018 08:20 PM, Omar Sandoval wrote: >> On Fri, Aug 17, 2018 at 12:16:07AM -0700, Omar Sandoval wrote: >>> On Thu, Aug 16, 2018 at 11:54:53PM -0700, Omar Sandoval wrote: On Thu, Aug 16, 2018 at 10:27:48PM -0700

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-09-04 Thread Tom de Vries
[ Adding Jason as addressee ] On 08/28/2018 08:20 PM, Omar Sandoval wrote: > On Fri, Aug 17, 2018 at 12:16:07AM -0700, Omar Sandoval wrote: >> On Thu, Aug 16, 2018 at 11:54:53PM -0700, Omar Sandoval wrote: >>> On Thu, Aug 16, 2018 at 10:27:48PM -0700, Andrew Pinski wrote: On Thu, Aug 16, 2018

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-28 Thread Omar Sandoval
On Fri, Aug 17, 2018 at 12:16:07AM -0700, Omar Sandoval wrote: > On Thu, Aug 16, 2018 at 11:54:53PM -0700, Omar Sandoval wrote: > > On Thu, Aug 16, 2018 at 10:27:48PM -0700, Andrew Pinski wrote: > > > On Thu, Aug 16, 2018 at 9:29 PM Omar Sandoval wrote: > > > > > > > > Hi, > > > > > > > > This fix

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-17 Thread Omar Sandoval
On Thu, Aug 16, 2018 at 11:54:53PM -0700, Omar Sandoval wrote: > On Thu, Aug 16, 2018 at 10:27:48PM -0700, Andrew Pinski wrote: > > On Thu, Aug 16, 2018 at 9:29 PM Omar Sandoval wrote: > > > > > > Hi, > > > > > > This fixes the issue that it is impossible to distinguish a zero-length > > > array

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-16 Thread Omar Sandoval
On Thu, Aug 16, 2018 at 10:27:48PM -0700, Andrew Pinski wrote: > On Thu, Aug 16, 2018 at 9:29 PM Omar Sandoval wrote: > > > > Hi, > > > > This fixes the issue that it is impossible to distinguish a zero-length > > array > > type from a flexible array type given the DWARF produced by GCC (which I

Re: [PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-16 Thread Andrew Pinski
On Thu, Aug 16, 2018 at 9:29 PM Omar Sandoval wrote: > > Hi, > > This fixes the issue that it is impossible to distinguish a zero-length array > type from a flexible array type given the DWARF produced by GCC (which I > reported here [1]). We do so by adding a DW_AT_count attribute with a value of

[PATCH] DWARF: add DW_AT_count to zero-length arrays

2018-08-16 Thread Omar Sandoval
Hi, This fixes the issue that it is impossible to distinguish a zero-length array type from a flexible array type given the DWARF produced by GCC (which I reported here [1]). We do so by adding a DW_AT_count attribute with a value of zero only for zero-length arrays (this is what clang does in thi