Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-10-01 Thread Jeff Law
On 9/18/19 2:04 AM, Martin Liška wrote: > PING^4 > > Just note that the author of the JSON implementation > in GCC is fine with the patch ;) OK if this is still pending :-) jeff

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-09-18 Thread Martin Liška
PING^4 Just note that the author of the JSON implementation in GCC is fine with the patch ;) Martin On 9/9/19 2:38 PM, Martin Liška wrote: > PING^3 > > On 8/30/19 10:55 AM, Martin Liška wrote: >> PING^2 >> >> On 8/26/19 2:34 PM, Martin Liška wrote: >>> PING^1 >>> >>> On 8/13/19 1:51 PM, Martin

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-09-09 Thread Martin Liška
PING^3 On 8/30/19 10:55 AM, Martin Liška wrote: > PING^2 > > On 8/26/19 2:34 PM, Martin Liška wrote: >> PING^1 >> >> On 8/13/19 1:51 PM, Martin Liška wrote: >>> On 8/2/19 2:40 PM, David Malcolm wrote: Something that occurred to me reading the updated patch: maybe it would make things ea

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-08-30 Thread Martin Liška
PING^2 On 8/26/19 2:34 PM, Martin Liška wrote: > PING^1 > > On 8/13/19 1:51 PM, Martin Liška wrote: >> On 8/2/19 2:40 PM, David Malcolm wrote: >>> Something that occurred to me reading the updated patch: maybe it would >>> make things easier to have utility member functions of json::object to >>>

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-08-26 Thread Martin Liška
PING^1 On 8/13/19 1:51 PM, Martin Liška wrote: > On 8/2/19 2:40 PM, David Malcolm wrote: >> Something that occurred to me reading the updated patch: maybe it would >> make things easier to have utility member functions of json::object to >> implicitly make the child, e.g.: >> >> void >> json::obje

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-08-13 Thread Martin Liška
On 8/2/19 2:40 PM, David Malcolm wrote: > Something that occurred to me reading the updated patch: maybe it would > make things easier to have utility member functions of json::object to > implicitly make the child, e.g.: > > void > json::object::set (const char *key, long v) > { >set (key, ne

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-08-02 Thread David Malcolm
On Fri, 2019-08-02 at 12:22 +0200, Martin Liška wrote: > On 7/31/19 3:13 PM, David Malcolm wrote: > > On Wed, 2019-07-31 at 10:42 +0200, Martin Liška wrote: > > > Hi. > > > > > > As seen here: > > > https://github.com/RPGillespie6/fastcov/pull/18/files/f184dd8b6fc > > > 14e0 > > > 75dfc0ea93de7be5

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-08-02 Thread Martin Liška
::float_number (exploc.column)); > > Likewise, integers here. > >>return obj; >> } >> >> @@ -207,7 +207,7 @@ json::object * >> optrecord_json_writer::profile_count_to_json (profile_count count) >> { >>json::object *ob

Re: [PATCH] Come up with json::integer_number and use it in GCOV.

2019-07-31 Thread David Malcolm
On Wed, 2019-07-31 at 10:42 +0200, Martin Liška wrote: > Hi. > > As seen here: > https://github.com/RPGillespie6/fastcov/pull/18/files/f184dd8b6fc14e0 > 75dfc0ea93de7be5c96298ddb#r308735088 > > GCOV uses json::number for branch count, line count and similar. > However, the json library > uses a d

[PATCH] Come up with json::integer_number and use it in GCOV.

2019-07-31 Thread Martin Liška
Hi. As seen here: https://github.com/RPGillespie6/fastcov/pull/18/files/f184dd8b6fc14e075dfc0ea93de7be5c96298ddb#r308735088 GCOV uses json::number for branch count, line count and similar. However, the json library uses a double as an internal representation for numbers. That's no desirable in