Re: [PATCH] Come up with {,UN}LIKELY macros.

2022-05-09 Thread Martin Liška
On 5/6/22 08:19, Richard Biener wrote: > But I would have been fine with LIKELY as well. Ok, so let's go with this version. I'm going to install the patch. Martin

Re: [PATCH] Come up with {,UN}LIKELY macros.

2022-05-05 Thread Richard Biener via Gcc-patches
On Thu, May 5, 2022 at 8:12 PM Martin Liška wrote: > > On 5/5/22 17:31, Segher Boessenkool wrote: > > On Thu, May 05, 2022 at 09:06:45AM -0400, Marek Polacek via Gcc-patches > > wrote: > >> On Thu, May 05, 2022 at 02:31:05PM +0200, Martin Liška wrote: > >>> Some parts of the compiler already defi

Re: [PATCH] Come up with {,UN}LIKELY macros.

2022-05-05 Thread Martin Liška
On 5/5/22 17:31, Segher Boessenkool wrote: > On Thu, May 05, 2022 at 09:06:45AM -0400, Marek Polacek via Gcc-patches wrote: >> On Thu, May 05, 2022 at 02:31:05PM +0200, Martin Liška wrote: >>> Some parts of the compiler already define: >>> #define likely(cond) __builtin_expect ((cond), 1) >>> >>> S

Re: [PATCH] Come up with {,UN}LIKELY macros.

2022-05-05 Thread Segher Boessenkool
On Thu, May 05, 2022 at 09:06:45AM -0400, Marek Polacek via Gcc-patches wrote: > On Thu, May 05, 2022 at 02:31:05PM +0200, Martin Liška wrote: > > Some parts of the compiler already define: > > #define likely(cond) __builtin_expect ((cond), 1) > > > > So the patch should unify it. > That's funny,

Re: [PATCH] Come up with {,UN}LIKELY macros.

2022-05-05 Thread Marek Polacek via Gcc-patches
On Thu, May 05, 2022 at 02:31:05PM +0200, Martin Liška wrote: > Some parts of the compiler already define: > #define likely(cond) __builtin_expect ((cond), 1) > > So the patch should unify it. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? >

[PATCH] Come up with {,UN}LIKELY macros.

2022-05-05 Thread Martin Liška
Some parts of the compiler already define: #define likely(cond) __builtin_expect ((cond), 1) So the patch should unify it. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/c/ChangeLog: * c-parser.cc (c_parser_conditional_e