Re: [PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Marek Polacek
On Mon, Oct 05, 2015 at 06:27:53PM +0200, Richard Biener wrote: > On October 5, 2015 4:46:44 PM GMT+02:00, Marek Polacek > wrote: > >On Mon, Oct 05, 2015 at 04:26:49PM +0200, Richard Biener wrote: > >> > > Otherwise other setters of SSA_NAME_RANGE_INFO would need to make > >> > > sure SSA_NAME_AN

Re: [PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Richard Biener
On October 5, 2015 4:46:44 PM GMT+02:00, Marek Polacek wrote: >On Mon, Oct 05, 2015 at 04:26:49PM +0200, Richard Biener wrote: >> > > Otherwise other setters of SSA_NAME_RANGE_INFO would need to make >> > > sure SSA_NAME_ANTI_RANGE_P is cleared as well. >> > >> > They mostly do, if I'm looking

Re: [PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Marek Polacek
On Mon, Oct 05, 2015 at 04:26:49PM +0200, Richard Biener wrote: > > > Otherwise other setters of SSA_NAME_RANGE_INFO would need to make > > > sure SSA_NAME_ANTI_RANGE_P is cleared as well. > > > > They mostly do, if I'm looking right, e.g. > > tree-ssa-phiopt.c:1016 > > tree-ssa-loop-im.c:1224 >

Re: [PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Richard Biener
On Mon, 5 Oct 2015, Marek Polacek wrote: > On Mon, Oct 05, 2015 at 04:08:05PM +0200, Richard Biener wrote: > > On Mon, 5 Oct 2015, Marek Polacek wrote: > > > > > Here, we were crashing on an assert in duplicate_ssa_name_range_info: > > > > > > 506 gcc_assert (!SSA_NAME_ANTI_RANGE_P (name)); >

Re: [PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Marek Polacek
On Mon, Oct 05, 2015 at 04:08:05PM +0200, Richard Biener wrote: > On Mon, 5 Oct 2015, Marek Polacek wrote: > > > Here, we were crashing on an assert in duplicate_ssa_name_range_info: > > > > 506 gcc_assert (!SSA_NAME_ANTI_RANGE_P (name)); > > > > The problem is that reset_flow_sensitive_info w

Re: [PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Richard Biener
On Mon, 5 Oct 2015, Marek Polacek wrote: > Here, we were crashing on an assert in duplicate_ssa_name_range_info: > > 506 gcc_assert (!SSA_NAME_ANTI_RANGE_P (name)); > > The problem is that reset_flow_sensitive_info wasn't clearing the > SSA_NAME_ANTI_RANGE_P flag; I don't think NULL SSA_NAME_R

[PATCH] Clear SSA_NAME_ANTI_RANGE_P when appropriate (PR tree-optimization/67821)

2015-10-05 Thread Marek Polacek
Here, we were crashing on an assert in duplicate_ssa_name_range_info: 506 gcc_assert (!SSA_NAME_ANTI_RANGE_P (name)); The problem is that reset_flow_sensitive_info wasn't clearing the SSA_NAME_ANTI_RANGE_P flag; I don't think NULL SSA_NAME_RANGE_INFO can ever describe an anti-range... Bootstra