Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-25 Thread Jeff Law
On 9/16/18 1:58 PM, Bernd Edlinger wrote: > Hi, > > this is a cleanup of the recently added strlen/strcpy/stpcpy > no nul warning code. > > Most importantly it moves the SSA_NAME handling from > unterminated_array to string_constant, thereby fixing > another round of xfails in the strlen and stpc

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-24 Thread Jeff Law
On 9/24/18 12:18 PM, Bernd Edlinger wrote: > On 09/24/18 19:48, Jeff Law wrote: >> On 9/16/18 1:58 PM, Bernd Edlinger wrote: >>> Hi, >>> >>> this is a cleanup of the recently added strlen/strcpy/stpcpy >>> no nul warning code. >>> >>> Most importantly it moves the SSA_NAME handling from >>> untermi

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-24 Thread Bernd Edlinger
On 09/24/18 19:48, Jeff Law wrote: > On 9/16/18 1:58 PM, Bernd Edlinger wrote: >> Hi, >> >> this is a cleanup of the recently added strlen/strcpy/stpcpy >> no nul warning code. >> >> Most importantly it moves the SSA_NAME handling from >> unterminated_array to string_constant, thereby fixing >> ano

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-24 Thread Jeff Law
On 9/16/18 1:58 PM, Bernd Edlinger wrote: > Hi, > > this is a cleanup of the recently added strlen/strcpy/stpcpy > no nul warning code. > > Most importantly it moves the SSA_NAME handling from > unterminated_array to string_constant, thereby fixing > another round of xfails in the strlen and stpc

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-23 Thread Jeff Law
On 9/22/18 12:32 PM, Martin Liška wrote: > Hi Jeff. > > I noticed that your commit r264328 introduced this: > > gcc/builtins.c: > ... >    579    tree rhs1 = gimple_assign_rhs1 (stmt); >    580    tree_code code = gimple_assign_rhs_code (stmt); >    581    if (code == ADDR_EXPR >    5

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-22 Thread Martin Liška
On 9/22/18 8:32 PM, Martin Liška wrote: Hi Jeff. I noticed that your commit r264328 introduced this: gcc/builtins.c: ...    579    tree rhs1 = gimple_assign_rhs1 (stmt);    580    tree_code code = gimple_assign_rhs_code (stmt);    581    if (code == ADDR_EXPR    582    &

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-22 Thread Martin Liška
Hi Jeff. I noticed that your commit r264328 introduced this: gcc/builtins.c: ... 579tree rhs1 = gimple_assign_rhs1 (stmt); 580tree_code code = gimple_assign_rhs_code (stmt); 581if (code == ADDR_EXPR 582&& TREE_CODE (TREE_OPERAND (rhs1, 0)) == ARRAY

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-18 Thread Jeff Law
On 9/18/18 5:44 AM, Bernd Edlinger wrote: >> > > Hmm, you know, I wrote a while ago the following: > https://gcc.gnu.org/ml/gcc-patches/2018-09/msg00411.html > > Where I suggested to change c_strlen parameter nonstr to a > structure, where additional information could go. It certainly seems bette

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-18 Thread Bernd Edlinger
On 09/18/18 07:31, Jeff Law wrote: > On 9/17/18 1:18 PM, Bernd Edlinger wrote: >> On 09/17/18 20:32, Jeff Law wrote: >>> On 9/17/18 12:20 PM, Bernd Edlinger wrote: On 09/17/18 19:33, Jeff Law wrote: > On 9/16/18 1:58 PM, Bernd Edlinger wrote: >> Hi, >> >> this is a cleanup of t

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-17 Thread Jeff Law
On 9/17/18 1:18 PM, Bernd Edlinger wrote: > On 09/17/18 20:32, Jeff Law wrote: >> On 9/17/18 12:20 PM, Bernd Edlinger wrote: >>> On 09/17/18 19:33, Jeff Law wrote: On 9/16/18 1:58 PM, Bernd Edlinger wrote: > Hi, > > this is a cleanup of the recently added strlen/strcpy/stpcpy >

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-17 Thread Jeff Law
On 9/17/18 1:18 PM, Bernd Edlinger wrote: > > I suppose the expr.c change will likely work alone, but > it was designed to replace the stuff here. > > So I will try to split the expr.c part out, and post it > tomorrow. It does work alone. I've already verified that here :-) BUt will probably ca

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-17 Thread Bernd Edlinger
On 09/17/18 20:32, Jeff Law wrote: > On 9/17/18 12:20 PM, Bernd Edlinger wrote: >> On 09/17/18 19:33, Jeff Law wrote: >>> On 9/16/18 1:58 PM, Bernd Edlinger wrote: Hi, this is a cleanup of the recently added strlen/strcpy/stpcpy no nul warning code. Most importantly it

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-17 Thread Jeff Law
On 9/17/18 12:20 PM, Bernd Edlinger wrote: > On 09/17/18 19:33, Jeff Law wrote: >> On 9/16/18 1:58 PM, Bernd Edlinger wrote: >>> Hi, >>> >>> this is a cleanup of the recently added strlen/strcpy/stpcpy >>> no nul warning code. >>> >>> Most importantly it moves the SSA_NAME handling from >>> untermi

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-17 Thread Bernd Edlinger
On 09/17/18 19:33, Jeff Law wrote: > On 9/16/18 1:58 PM, Bernd Edlinger wrote: >> Hi, >> >> this is a cleanup of the recently added strlen/strcpy/stpcpy >> no nul warning code. >> >> Most importantly it moves the SSA_NAME handling from >> unterminated_array to string_constant, thereby fixing >> ano

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-17 Thread Jeff Law
On 9/16/18 1:58 PM, Bernd Edlinger wrote: > Hi, > > this is a cleanup of the recently added strlen/strcpy/stpcpy > no nul warning code. > > Most importantly it moves the SSA_NAME handling from > unterminated_array to string_constant, thereby fixing > another round of xfails in the strlen and stpc

[PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-16 Thread Bernd Edlinger
Hi, this is a cleanup of the recently added strlen/strcpy/stpcpy no nul warning code. Most importantly it moves the SSA_NAME handling from unterminated_array to string_constant, thereby fixing another round of xfails in the strlen and stpcpy test cases. I need to say that the fix for bug 86622 i