Re: [PATCH] Cleanup of input.c

2016-10-01 Thread Bernd Edlinger
On 10/01/16 00:16, David Malcolm wrote: > On Mon, 2016-09-26 at 14:30 +, Bernd Edlinger wrote: >> Hi, >> >> this started, because I saw get_next_line returns -1 on error, >> instead >> of false: PR 77699. >> >> But when I was there I also saw that read_line_num is using memmove >> on >> non-ali

Re: [PATCH] Cleanup of input.c

2016-09-30 Thread David Malcolm
On Mon, 2016-09-26 at 14:30 +, Bernd Edlinger wrote: > Hi, > > this started, because I saw get_next_line returns -1 on error, > instead > of false: PR 77699. > > But when I was there I also saw that read_line_num is using memmove > on > non-aliased src & dest, instead of memcpy. But then I s

[PATCH] Cleanup of input.c

2016-09-26 Thread Bernd Edlinger
Hi, this started, because I saw get_next_line returns -1 on error, instead of false: PR 77699. But when I was there I also saw that read_line_num is using memmove on non-aliased src & dest, instead of memcpy. But then I see that also adding a NUL byte is superfluos, and all the copying as well..