Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-27 Thread Richard Biener
On Tue, Nov 27, 2012 at 3:54 PM, Dehao Chen wrote: > On Tue, Nov 27, 2012 at 1:46 AM, Richard Biener > wrote: >> On Mon, Nov 26, 2012 at 11:54 PM, Dehao Chen wrote: >>> The new patch is attached. Bootstrapped and passed gcc regression test. >>> >>> Ok for trunk? >> >> Hmm ... this merely avoids

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-27 Thread Dehao Chen
On Tue, Nov 27, 2012 at 1:46 AM, Richard Biener wrote: > On Mon, Nov 26, 2012 at 11:54 PM, Dehao Chen wrote: >> The new patch is attached. Bootstrapped and passed gcc regression test. >> >> Ok for trunk? > > Hmm ... this merely avoids some UNKNOWN_LOCATIONs which should > be ok. I think the issu

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-27 Thread Richard Biener
On Mon, Nov 26, 2012 at 11:54 PM, Dehao Chen wrote: > The new patch is attached. Bootstrapped and passed gcc regression test. > > Ok for trunk? Hmm ... this merely avoids some UNKNOWN_LOCATIONs which should be ok. I think the issue is that gimplify_expr does: saved_location = input_location;

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Dehao Chen
The new patch is attached. Bootstrapped and passed gcc regression test. Ok for trunk? Thanks, Dehao gcc/ChangeLog: 2010-11-05 Dehao Chen * ipa-prop.c (ipa_modify_call_arguments): Set loc correctly. * emit-rtl.c (last_location): Remove unused variable. Index: gcc/emit-rtl.c =

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Dehao Chen
On Mon, Nov 26, 2012 at 8:10 AM, Richard Biener wrote: > On Mon, Nov 26, 2012 at 4:54 PM, Dehao Chen wrote: >> On Mon, Nov 26, 2012 at 7:28 AM, Richard Biener >> wrote: >>> On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: ping... >>> >>> The emit-rtl.c hunk is ok. I'm questioning the ipa

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Richard Biener
On Mon, Nov 26, 2012 at 4:54 PM, Dehao Chen wrote: > On Mon, Nov 26, 2012 at 7:28 AM, Richard Biener > wrote: >> On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: >>> ping... >> >> The emit-rtl.c hunk is ok. I'm questioning the ipa-prop.c hunk though - what >> looks at input_location (nothing o

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Dehao Chen
On Mon, Nov 26, 2012 at 7:28 AM, Richard Biener wrote: > On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: >> ping... > > The emit-rtl.c hunk is ok. I'm questioning the ipa-prop.c hunk though - what > looks at input_location (nothing outside of the frontend should, really). ipa_modify_call_argu

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-26 Thread Richard Biener
On Thu, Nov 8, 2012 at 6:39 PM, Dehao Chen wrote: > ping... The emit-rtl.c hunk is ok. I'm questioning the ipa-prop.c hunk though - what looks at input_location (nothing outside of the frontend should, really). Thanks, Richard. > > On Mon, Nov 5, 2012 at 5:20 PM, Dehao Chen wrote: >> >> Hi, >

Re: [PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-08 Thread Dehao Chen
ping... On Mon, Nov 5, 2012 at 5:20 PM, Dehao Chen wrote: > > Hi, > > This is a patch to do some obvious cleanup and setting correct > input_location in ipa_prop (because it invokes gimplification > routines). > > Bootstrapped and passed gcc regression tests. > > Is it okay for trunk? > > Thanks

[PATCH] Cleanup last_location and update input_location in ipa_prop

2012-11-05 Thread Dehao Chen
Hi, This is a patch to do some obvious cleanup and setting correct input_location in ipa_prop (because it invokes gimplification routines). Bootstrapped and passed gcc regression tests. Is it okay for trunk? Thanks, Dehao gcc/ChangeLog: 2010-11-05 Dehao Chen * ipa-prop.c (ipa_modif