Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-25 Thread Tom de Vries
On 23/06/15 11:31, Richard Biener wrote: On Mon, Jun 22, 2015 at 7:10 PM, Tom de Vries wrote: On 22/06/15 13:47, Richard Biener wrote: (eventually also for the case where we end up only computing the fast-query stuff). Like this? ... diff --git a/gcc/dominance.c b/gcc/dominance.c index 9

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-23 Thread Richard Biener
On Mon, Jun 22, 2015 at 7:10 PM, Tom de Vries wrote: > On 22/06/15 13:47, Richard Biener wrote: >>> >>> (eventually also for the case where we >>> >>end up only computing the fast-query stuff). >>> > > Like this? > ... > diff --git a/gcc/dominance.c b/gcc/dominance.c > index 9c66ca2..58fc6fd 10064

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
On 22/06/15 13:47, Richard Biener wrote: (eventually also for the case where we >>end up only computing the fast-query stuff). Like this? ... diff --git a/gcc/dominance.c b/gcc/dominance.c index 9c66ca2..58fc6fd 100644 --- a/gcc/dominance.c +++ b/gcc/dominance.c @@ -679,6 +679,12 @@ calculate_

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
On 22/06/15 13:47, Richard Biener wrote: On Mon, Jun 22, 2015 at 1:33 PM, Tom de Vries wrote: On 22/06/15 12:14, Richard Biener wrote: On Mon, Jun 22, 2015 at 10:04 AM, Tom de Vries wrote: Hi, during development of a patch I ran into a case where compute_dominance_frontiers was called wit

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Richard Biener
On Mon, Jun 22, 2015 at 1:33 PM, Tom de Vries wrote: > On 22/06/15 12:14, Richard Biener wrote: >> >> On Mon, Jun 22, 2015 at 10:04 AM, Tom de Vries >> wrote: >>> >>> Hi, >>> >>> during development of a patch I ran into a case where >>> compute_dominance_frontiers was called with incorrect domina

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
On 22/06/15 12:14, Richard Biener wrote: On Mon, Jun 22, 2015 at 10:04 AM, Tom de Vries wrote: Hi, during development of a patch I ran into a case where compute_dominance_frontiers was called with incorrect dominance info. The result was a segmentation violation somewhere in the bitmap code w

Re: [PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Richard Biener
On Mon, Jun 22, 2015 at 10:04 AM, Tom de Vries wrote: > Hi, > > during development of a patch I ran into a case where > compute_dominance_frontiers was called with incorrect dominance info. > > The result was a segmentation violation somewhere in the bitmap code while > executing this bitmap_set_b

[PATCH] Check dominator info in compute_dominance_frontiers

2015-06-22 Thread Tom de Vries
Hi, during development of a patch I ran into a case where compute_dominance_frontiers was called with incorrect dominance info. The result was a segmentation violation somewhere in the bitmap code while executing this bitmap_set_bit in compute_dominance_frontiers_1: ... if