Re: [PATCH] Check always_inline flag in s390_can_inline_p [PR104327]

2022-02-07 Thread Andreas Krebbel via Gcc-patches
On 2/7/22 09:11, Jakub Jelinek wrote: ... > 1) formatting, = should be at the start of next line rather than end of the >line > 2) all_masks, always_inline_safe_masks and caller_required_masks aren't >ever modified, perhaps make them const? > 3) I wonder if there is any advantage to have al

Re: [PATCH] Check always_inline flag in s390_can_inline_p [PR104327]

2022-02-07 Thread Jakub Jelinek via Gcc-patches
On Mon, Feb 07, 2022 at 08:09:47AM +0100, Andreas Krebbel via Gcc-patches wrote: > MASK_MVCLE is set for -Os but not for other optimization levels. In > general it should not make much sense to inline across calls where the > flag is different but we have to allow it for always_inline. > > The pat

[PATCH] Check always_inline flag in s390_can_inline_p [PR104327]

2022-02-06 Thread Andreas Krebbel via Gcc-patches
MASK_MVCLE is set for -Os but not for other optimization levels. In general it should not make much sense to inline across calls where the flag is different but we have to allow it for always_inline. The patch also rearranges the hook implementation a bit based on the recommendations from Jakub un