Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread James K. Lowden
On Mon, 17 Feb 2025 15:13:21 -0500 David Malcolm wrote: > > How do I do that?  I barely know the term; I have to look it up > > every time.  I don't find "sarif" anywhere in gcc.info or > > gccint.info.  > > (caveat: SARIF is one of my particular interests and thus I'm biased > towards it; not

Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread James K. Lowden
On Mon, 17 Feb 2025 15:02:35 -0500 David Malcolm wrote: > > (Maybe zero_option_id would be a better name?) > > Ah - yes, now I see what you mean. I like that name. > > Can it be "const"? Already is! I renamed it to "option_zero" to prevent future confusion. --jkl

RE: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread Robert Dubner
> -Original Message- > From: Richard Biener > Sent: Monday, February 17, 2025 08:24 > To: James K. Lowden > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] COBOL 8/15 360K cbl: parser support > > On Sat, Feb 15, 2025 at 10:08 PM James K. Lowde

Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread David Malcolm
On Mon, 2025-02-17 at 12:49 -0500, James K. Lowden wrote: > On Sat, 15 Feb 2025 23:37:20 -0500 > David Malcolm wrote: > > > +const char * > > +cobol_get_sarif_source_language(const char *) > > +    { > > +    return "cobol"; > > +    } > > > > Out of curiosity, did you try the SARIF output?  Thi

Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread David Malcolm
On Mon, 2025-02-17 at 12:42 -0500, James K. Lowden wrote: > On Sat, 15 Feb 2025 23:37:20 -0500 > David Malcolm wrote: > > > +  rich_location richloc (line_table, token_location); > > +  bool ret = global_dc->diagnostic_impl (&richloc, nullptr, > > option_id, > > + 

Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread James K. Lowden
On Sat, 15 Feb 2025 23:37:20 -0500 David Malcolm wrote: > +const char * > +cobol_get_sarif_source_language(const char *) > +{ > +return "cobol"; > +} > > Out of curiosity, did you try the SARIF output? This is a good test > for whether you?re properly using the GCC diagnostics subsy

Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-17 Thread James K. Lowden
On Sat, 15 Feb 2025 23:37:20 -0500 David Malcolm wrote: > + rich_location richloc (line_table, token_location); > + bool ret = global_dc->diagnostic_impl (&richloc, nullptr, > option_id, > + gmsgid, &ap, DK_ERROR); > + va_end (ap); > + global_dc->end_gr

Re: [PATCH] COBOL 8/15 360K cbl: parser support

2025-02-15 Thread David Malcolm
On Sat, 2025-02-15 at 16:01 -0500, James K. Lowden wrote: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 - > 0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:53 PM EST > Subject: [PATCH] 9 new 'cobol' FE files > > gcc/cobol/ChangeLog > * cdf.y: New file. >