Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Andrew Stubbs
445891ba57e858d980441bd63249e3bc94632db3 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Fri, 26 Jan 2024 12:57:10 +0100 Subject: [PATCH] Avoid registering unsupported OMP offload devices To: gcc-patches@gcc.gnu.org The following avoids registering unsupported GCN offload devices when iterati

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Andrew Stubbs
ichard Biener Date: Fri, 26 Jan 2024 12:57:10 +0100 Subject: [PATCH] Avoid registering unsupported OMP offload devices To: gcc-patches@gcc.gnu.org The following avoids registering unsupported GCN offload devices when iterating over available ones. With a Zen4 desktop CPU you will have an IGPU (unsp

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Richard Biener
ling the function > (unless it has to be initialized) and strcpy it to nil or something similar > if it fails. Yeah, sorry. Here's a proper engineered variant. I don't expect that function to ever fail of course. >From 445891ba57e858d980441bd63249e3bc94632db3 Mon Sep 17

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Jakub Jelinek
On Fri, Jan 26, 2024 at 03:04:11PM +0100, Richard Biener wrote: > > > Otherwise it looks reasoanble to me, but let's see what Andrew thinks. > > > > 'n' before 'a', please. ;-) > > ?! I've misspelled a word. > @@ -1443,6 +1445,16 @@ suitable_hsa_agent_p (hsa_agent_t agent) >switch (device_t

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Richard Biener
GCN debug: HSA run-time initialized for GCN GCN debug: HSA_SYSTEM_INFO_ENDIANNESS: LITTLE GCN debug: HSA_SYSTEM_INFO_EXTENSIONS: IMAGES GCN debug: Ignoring unsupported agent 'gfx1036' GCN debug: There are 1 GCN GPU devices. GCN debug: Ignoring unsupported agent 'gfx1036' GCN deb

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Andrew Stubbs
On 26/01/2024 12:06, Jakub Jelinek wrote: On Fri, Jan 26, 2024 at 01:00:28PM +0100, Richard Biener wrote: The following avoids registering unsupported GCN offload devices when iterating over available ones. With a Zen4 desktop CPU you will have an IGPU (unspported) which will otherwise be made

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Richard Biener
On Fri, 26 Jan 2024, Tobias Burnus wrote: > Jakub Jelinek wrote: > > On Fri, Jan 26, 2024 at 01:00:28PM +0100, Richard Biener wrote: > >> libgomp/ > >> * plugin/plugin-gcn.c (suitable_hsa_agent_p): Filter out > >> agents with unsupported ISA. > ... > >> @@ -1443,6 +1445,13 @@ suitable_hsa_agent_

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Tobias Burnus
Jakub Jelinek wrote: On Fri, Jan 26, 2024 at 01:00:28PM +0100, Richard Biener wrote: libgomp/ * plugin/plugin-gcn.c (suitable_hsa_agent_p): Filter out agents with unsupported ISA. ... @@ -1443,6 +1445,13 @@ suitable_hsa_agent_p (hsa_agent_t agent) switch (device_type)

Re: [PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Jakub Jelinek
On Fri, Jan 26, 2024 at 01:00:28PM +0100, Richard Biener wrote: > The following avoids registering unsupported GCN offload devices > when iterating over available ones. With a Zen4 desktop CPU > you will have an IGPU (unspported) which will otherwise be made > available. This causes testcases lik

[PATCH] Avoid registering unsupported OMP offload devices

2024-01-26 Thread Richard Biener
The following avoids registering unsupported GCN offload devices when iterating over available ones. With a Zen4 desktop CPU you will have an IGPU (unspported) which will otherwise be made available. This causes testcases like libgomp.c-c++-common/non-rect-loop-1.c which iterate over all decives