Re: [PATCH] Avoid calling tracer.trailer() twice.

2022-10-11 Thread Andrew MacLeod via Gcc-patches
perfect. On 10/11/22 10:08, Aldy Hernandez wrote: Sure. OK? Aldy On Tue, Oct 11, 2022 at 3:11 PM Andrew MacLeod wrote: It probably should just be changed to a print if it doesn't return.. something like if (idx && res) { tracer.print (idx, "logical_combine produced"); r.dump

Re: [PATCH] Avoid calling tracer.trailer() twice.

2022-10-11 Thread Aldy Hernandez via Gcc-patches
_false) > > && logical_combine (r, code, m_bool_one, op1_true, op1_false, > > op2_true, op2_false)) > > - { > > - r.union_ (r1); > > - res = true; > > - } > > - else > > - res = false; > &g

Re: [PATCH] Avoid calling tracer.trailer() twice.

2022-10-11 Thread Andrew MacLeod via Gcc-patches
It probably should just be changed to a print if it doesn't return.. something like if (idx && res) { tracer.print (idx, "logical_combine produced"); r.dump (dump_file); fputc ('\n', dump_file); } Andrew On 10/10/22 14:58, Aldy Hernandez wrote: [Andrew, you OK with this? I c

[PATCH] Avoid calling tracer.trailer() twice.

2022-10-10 Thread Aldy Hernandez via Gcc-patches
[Andrew, you OK with this? I can't tell whether the trailer() call was actually needed.] logical_combine is calling tracer.trailer() one too many times causing the second trailer() call to subtract a 0 indent by 2, yielding an indent of SOMETHING_REALLY_BIG :). You'd be surprised how many tools