Re: [PATCH] Avoid -Werror=format-security errors in libcpp

2015-01-16 Thread Joseph Myers
On Fri, 16 Jan 2015, Jakub Jelinek wrote: > Anyway, in that case guess we also need to change unrelated: > > --- libcpp/expr.c.jj 2015-01-05 13:07:21.0 +0100 > +++ libcpp/expr.c 2015-01-16 12:54:56.517522643 +0100 > @@ -696,9 +696,9 @@ cpp_classify_number (cpp_reader *pfile, >

Re: [PATCH] Avoid -Werror=format-security errors in libcpp

2015-01-16 Thread Jakub Jelinek
On Thu, Jan 15, 2015 at 09:38:19PM +, Joseph Myers wrote: > On Thu, 15 Jan 2015, Jakub Jelinek wrote: > > > --- libcpp/expr.c.jj2015-01-14 11:01:34.0 +0100 > > +++ libcpp/expr.c 2015-01-14 14:35:52.851002344 +0100 > > @@ -672,16 +672,17 @@ cpp_classify_number (cpp_reader *pfi

Re: [PATCH] Avoid -Werror=format-security errors in libcpp

2015-01-15 Thread Joseph Myers
On Thu, 15 Jan 2015, Jakub Jelinek wrote: > --- libcpp/expr.c.jj 2015-01-14 11:01:34.0 +0100 > +++ libcpp/expr.c 2015-01-14 14:35:52.851002344 +0100 > @@ -672,16 +672,17 @@ cpp_classify_number (cpp_reader *pfile, >if ((result & CPP_N_WIDTH) == CPP_N_LARGE > && CPP_OPTI

Re: [PATCH] Avoid -Werror=format-security errors in libcpp

2015-01-15 Thread Jeff Law
On 01/15/15 04:19, Jakub Jelinek wrote: Hi! With the addition of build libcpp, my build failed because of distro default flags of -Werror=format-security. The first hunk is I think no big deal, making it const makes the warning go away. The second hunk is more controversial, as even making mes

[PATCH] Avoid -Werror=format-security errors in libcpp

2015-01-15 Thread Jakub Jelinek
Hi! With the addition of build libcpp, my build failed because of distro default flags of -Werror=format-security. The first hunk is I think no big deal, making it const makes the warning go away. The second hunk is more controversial, as even making message const doesn't help with the warning.