Re: [PATCH] Assorted optc-save-gen.awk fixes (PR bootstrap/90543)

2019-09-29 Thread Jakub Jelinek
On Sun, Sep 29, 2019 at 06:34:04PM +1000, Michael Chamberlain wrote: > The last line modified above will print ptr1->..., but I think it should be > using ptr2 both in the condition and the true alternative. You're right, fixed thusly, committed as obvious to trunk so far, will backport to 9.3 too

Re: Patch ping (was Re: [PATCH] Assorted optc-save-gen.awk fixes (PR bootstrap/90543))

2019-05-29 Thread Richard Biener
On Wed, 29 May 2019, Jakub Jelinek wrote: > On Wed, May 22, 2019 at 01:41:56PM +0200, Jakub Jelinek wrote: > > 2019-05-22 Jakub Jelinek > > > > PR bootstrap/90543 > > * optc-save-gen.awk: In cl_optimization_print, use correct condition > > for var_opt_string printing. In cl_optimi

Patch ping (was Re: [PATCH] Assorted optc-save-gen.awk fixes (PR bootstrap/90543))

2019-05-29 Thread Jakub Jelinek
On Wed, May 22, 2019 at 01:41:56PM +0200, Jakub Jelinek wrote: > 2019-05-22 Jakub Jelinek > > PR bootstrap/90543 > * optc-save-gen.awk: In cl_optimization_print, use correct condition > for var_opt_string printing. In cl_optimization_print_diff, print > (null) instead o

Re: [PATCH] Assorted optc-save-gen.awk fixes (PR bootstrap/90543)

2019-05-22 Thread Jakub Jelinek
On Wed, May 22, 2019 at 01:41:56PM +0200, Jakub Jelinek wrote: > Ok for trunk if it passes full bootstrap/regtest on x86_64-linux (passed > already normal build on aarch64-linux cross)? Successfully bootstrapped/regtested on x86_64-linux and i686-linux. > 2019-05-22 Jakub Jelinek > > PR

[PATCH] Assorted optc-save-gen.awk fixes (PR bootstrap/90543)

2019-05-22 Thread Jakub Jelinek
On Wed, May 22, 2019 at 01:27:04PM +0200, Jakub Jelinek wrote: > No, IMHO you do want to use %s, patch below. I've found a couple of other > bugs in optc-save-gen.awk. Attached is a diff between aarch64 target > options-save.c before and after this patch. > > The other bugs were that cl_optimiza