Re: [PATCH] Assigning correct source location for deallocator

2012-10-10 Thread Dehao Chen
This patch was committed and ported to google-4_7 branch. Thanks, Dehao gcc/ChangeLog: 2012-10-07 Dehao Chen * tree-eh.c (lower_try_finally_onedest): Set correct location for deallocator. * gimplify.c (gimplify_expr): Set correct location for TRY stmt. gcc/cp/ChangeLog: 2012-10-07 Dehao C

Re: [PATCH] Assigning correct source location for deallocator

2012-10-09 Thread Jason Merrill
OK. Jason

Re: [PATCH] Assigning correct source location for deallocator

2012-10-09 Thread Dehao Chen
The patch bootstrapped and passed gcc regression tests. Thanks, Dehao On Tue, Oct 9, 2012 at 1:16 PM, Dehao Chen wrote: > Yes, you are right. I've changed to use EXPR_LOCATION (stmt) for the location. > > New patch attached, testing is on-going. > > Thanks, > Dehao > > On Tue, Oct 9, 2012 at 12:

Re: [PATCH] Assigning correct source location for deallocator

2012-10-09 Thread Dehao Chen
Yes, you are right. I've changed to use EXPR_LOCATION (stmt) for the location. New patch attached, testing is on-going. Thanks, Dehao On Tue, Oct 9, 2012 at 12:35 PM, Jason Merrill wrote: > On 10/07/2012 08:38 PM, Dehao Chen wrote: >> >> +*stmt_p = build2_loc (input_location, > > > I think

Re: [PATCH] Assigning correct source location for deallocator

2012-10-09 Thread Jason Merrill
On 10/07/2012 08:38 PM, Dehao Chen wrote: +*stmt_p = build2_loc (input_location, I think input_location in cp_genericize_r will always be the closing brace of the function, which might be right for a variable in the outermost block of the function, but not for variables in inner scopes.

[PATCH] Assigning correct source location for deallocator

2012-10-07 Thread Dehao Chen
Hi, R191338 did not completely fix the location for deallocator. This patch covers more cases for deallocator. Bootstrapped and passed gcc regression test on x86. Okay for trunk? Thanks, Dehao gcc/ChangeLog: 2012-10-07 Dehao Chen * tree-eh.c (lower_try_finally_onedest): Set correct locati