Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-12-02 Thread Bernd Schmidt
On 12/02/2015 08:05 PM, Jeff Law wrote: On 11/27/2015 07:09 AM, Dominik Vogt wrote: New patch with the following changes: * Fixed comment about dynamic var area placement. * The area is now placed further away from the stack pointer than the non-dynamic stack variables (tested only with S

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-12-02 Thread Jeff Law
On 11/27/2015 07:09 AM, Dominik Vogt wrote: New patch with the following changes: * Fixed comment about dynamic var area placement. * The area is now placed further away from the stack pointer than the non-dynamic stack variables (tested only with STACK_GROWS_DOWNWARD). This is a possible

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-27 Thread Dominik Vogt
On Fri, Nov 27, 2015 at 03:09:15PM +0100, Dominik Vogt wrote: > +++ b/gcc/config/s390/s390.h ... > +/* Constant size dynamic stack space can be allocated through the function > + prologue to save the extra instructions to adjust the stack pointer. */ > +#define ALLOCATE_DYNAMIC_STACK_SPACE_IN_PR

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-27 Thread Dominik Vogt
New patch with the following changes: * Fixed comment about dynamic var area placement. * The area is now placed further away from the stack pointer than the non-dynamic stack variables (tested only with STACK_GROWS_DOWNWARD). This is a possible performance improvement on S/390 (hoping that

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-25 Thread Bernd Schmidt
On 11/25/2015 03:52 PM, Dominik Vogt wrote: Without looking into the details, I believe it's an optimization to have certain frequently used members of the struct always on the same cache line. Probably better to annotate the global vars then with an alignment, rather than waste space on the s

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-25 Thread Dominik Vogt
On Wed, Nov 25, 2015 at 02:31:38PM +0100, Bernd Schmidt wrote: > On 11/25/2015 01:56 PM, Dominik Vogt wrote: > >The attached patch fixes a warning during Linux kernel compilation > >on S/390 due to -mwarn-dynamicstack and runtime alignment of stack > >variables with constant size causing cfun->call

Re: [PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-25 Thread Bernd Schmidt
On 11/25/2015 01:56 PM, Dominik Vogt wrote: The attached patch fixes a warning during Linux kernel compilation on S/390 due to -mwarn-dynamicstack and runtime alignment of stack variables with constant size causing cfun->calls_alloca to be set (even if alloca is not used at all). The patched cod

[PATCH] Allocate constant size dynamic stack space in the prologue

2015-11-25 Thread Dominik Vogt
5:50 +0100 Subject: [PATCH] Allocate constant size dynamic stack space in the prologue ... ... and place it in the virtual stack vars area, if the platform supports it. On S/390 this saves adjusting the stack pointer twice and forcing the frame pointer into existence. It also removes the warn