Re: [PATCH] Add qsort comparator consistency checking (PR71702)

2016-07-20 Thread Richard Biener
On Tue, Jul 19, 2016 at 3:27 PM, Alexander Monakov wrote: > On Tue, 19 Jul 2016, Richard Biener wrote: >> Yes. The other option is to enable this checking not with ENABLE_CHECKING >> but some new checking option, say ENABLE_CHECKING_ALGORITHMS, and >> do full checking in that case. > > Thanks - I

Re: [PATCH] Add qsort comparator consistency checking (PR71702)

2016-07-19 Thread Alexander Monakov
On Tue, 19 Jul 2016, Richard Biener wrote: > Yes. The other option is to enable this checking not with ENABLE_CHECKING > but some new checking option, say ENABLE_CHECKING_ALGORITHMS, and > do full checking in that case. Thanks - I'm going to fold in this idea when redoing the patch (i.e. check a

Re: [PATCH] Add qsort comparator consistency checking (PR71702)

2016-07-19 Thread Richard Biener
On Mon, Jul 18, 2016 at 7:36 PM, Alexander Monakov wrote: > On Mon, 18 Jul 2016, Richard Biener wrote: >> Ugh. What impact does this have on stage2 compile-time? > > It doesn't seem to be high enough to be measured reliably. I've made a trial > run with -time=time.log in BOOT_CFLAGS, but there's

Re: [PATCH] Add qsort comparator consistency checking (PR71702)

2016-07-18 Thread Alexander Monakov
On Mon, 18 Jul 2016, Richard Biener wrote: > Ugh. What impact does this have on stage2 compile-time? It doesn't seem to be high enough to be measured reliably. I've made a trial run with -time=time.log in BOOT_CFLAGS, but there's a lot of variability in timings and the sum total of times ended u

Re: [PATCH] Add qsort comparator consistency checking (PR71702)

2016-07-18 Thread Richard Biener
On Fri, Jul 15, 2016 at 6:00 PM, Alexander Monakov wrote: > Hi, > > this patch adds internal checking for comparator functions that GCC passes to > qsort. PR71702 describes an ICE that happens because comparator > 'dr_group_sort_cmp' used to be non-transitive in some cases until GCC 6. This > pa

[PATCH] Add qsort comparator consistency checking (PR71702)

2016-07-15 Thread Alexander Monakov
Hi, this patch adds internal checking for comparator functions that GCC passes to qsort. PR71702 describes an ICE that happens because comparator 'dr_group_sort_cmp' used to be non-transitive in some cases until GCC 6. This patch would uncover that issue on a number of small testcases in GCC's t