> > > + if (TREE_CHAIN (pp_val) != NULL_TREE)
> >> > > > > > + {
> >> > > > > > + tree patchable_function_entry_value2
> >> > > > > > + = TREE_VALUE (TREE_CHAIN (pp_val));
> >> > > &
> > > > + patch_area_entry = tree_to_uhwi
>> > > > > > (patchable_function_entry_value2);
>> > > > > > + }
>> > > > > > + if (patch_area_size > USHRT_MAX || patch_area_size >
>> > > >
HRT_MAX || patch_area_size >
> > > > > > USHRT_MAX)
> > > > > > + error ("invalid values for %
> > > > > > attribute");
> > > > >
> > > > > This should probably go in handle_patchable_function_ent
On Wed, Feb 5, 2020 at 2:37 PM Marek Polacek wrote:
>
> On Wed, Feb 05, 2020 at 02:24:48PM -0800, H.J. Lu wrote:
> > On Wed, Feb 5, 2020 at 12:20 PM H.J. Lu wrote:
> > >
> > > On Wed, Feb 5, 2020 at 9:00 AM Richard Sandiford
> > > wrote:
> > > >
> > > > "H.J. Lu" writes:
> > > > > Currently pat
On Wed, Feb 05, 2020 at 02:24:48PM -0800, H.J. Lu wrote:
> On Wed, Feb 5, 2020 at 12:20 PM H.J. Lu wrote:
> >
> > On Wed, Feb 5, 2020 at 9:00 AM Richard Sandiford
> > wrote:
> > >
> > > "H.J. Lu" writes:
> > > > Currently patchable area is at the wrong place.
> > >
> > > Agreed :-)
> > >
> > > >
On Wed, Feb 5, 2020 at 12:20 PM H.J. Lu wrote:
>
> On Wed, Feb 5, 2020 at 9:00 AM Richard Sandiford
> wrote:
> >
> > "H.J. Lu" writes:
> > > Currently patchable area is at the wrong place.
> >
> > Agreed :-)
> >
> > > It is placed immediately
> > > after function label and before .cfi_startproc.
a_size > USHRT_MAX || patch_area_size > USHRT_MAX)
> > + error ("invalid values for % attribute");
>
> This should probably go in handle_patchable_function_entry_attribute
> instead. It doesn't look like we have a clear policy about whether
> errors or
