Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-09-15 Thread Yao Qi
On Sat, Sep 9, 2017 at 1:27 PM, Ian Lance Taylor wrote: > > The patch to include/ansidecl.h is basically OK. Please add an > example in the comment showing how to use it: after `private:`, and > with a trailing semicolon. Thanks. Patch below is committed. Thanks for the review. > > The patche

Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-09-09 Thread Ian Lance Taylor
On Sat, Sep 9, 2017 at 2:45 AM, Yao Qi wrote: > On Fri, Aug 11, 2017 at 3:14 PM, Pedro Alves >> Yeah, this is a macro that lots of projects out there reinvent, >> can't imagine it being very controversial. >> >> I could have used this today in another spot in gdb. >> >> The patch as is touches are

Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-09-09 Thread Yao Qi
On Fri, Aug 11, 2017 at 3:14 PM, Pedro Alves > Yeah, this is a macro that lots of projects out there reinvent, > can't imagine it being very controversial. > > I could have used this today in another spot in gdb. > > The patch as is touches areas with different maintainers, it > may have fallen vic

Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-08-11 Thread Pedro Alves
On 08/02/2017 12:19 PM, Yao Qi wrote: > On Wed, Jul 26, 2017 at 9:55 AM, Yao Qi wrote: >> On 17-07-19 10:30:45, Yao Qi wrote: >>> We have many classes that copy cotr and assignment operator are deleted >>> in different projects, gcc, gdb and gold. So this patch adds a macro >>> to do this, and re

Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-08-02 Thread Yao Qi
On Wed, Jul 26, 2017 at 9:55 AM, Yao Qi wrote: > On 17-07-19 10:30:45, Yao Qi wrote: >> We have many classes that copy cotr and assignment operator are deleted >> in different projects, gcc, gdb and gold. So this patch adds a macro >> to do this, and replace these existing mechanical code with ma

Re: [PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-07-26 Thread Yao Qi
On 17-07-19 10:30:45, Yao Qi wrote: > We have many classes that copy cotr and assignment operator are deleted > in different projects, gcc, gdb and gold. So this patch adds a macro > to do this, and replace these existing mechanical code with macro > DISABLE_COPY_AND_ASSIGN. > > The patch was pos

[PATCH] Add macro DISABLE_COPY_AND_ASSIGN

2017-07-19 Thread Yao Qi
We have many classes that copy cotr and assignment operator are deleted in different projects, gcc, gdb and gold. So this patch adds a macro to do this, and replace these existing mechanical code with macro DISABLE_COPY_AND_ASSIGN. The patch was posted in gdb-patches, https://sourceware.org/ml/gd